[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18838 Let's close this PR, since the original behavior was by design. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18838 Could we close this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/spark/pull/18838 @jerryshao Thanks for your reply. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18838 I think the original purpose is to void reusing the directory and always create a unique directory. So with the change here seems the semantics is changed, I don't think it is a reasonable fix

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18838 This introduces an NPE. It also changes what happens when the dir exists. I don't see a problem that this solves, so I'd close this. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/spark/pull/18838 @srowen Yes,I change the logic because I think it's no mean to attempt to create a dir while there was a same name dir. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18838 This changes the logic and I'm not clear why it's an improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #18838: [SPARK-21632] There is no need to make attempts for crea...

2017-08-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18838 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this