Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
Thanks @HyukjinKwon @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18869
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18869
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
@HyukjinKwon @gatorsmile Any more comments on this? The added tests should
be enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81362/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81362/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81362/testReport)**
for PR 18869 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81359/
Test FAILed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81359/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81359/testReport)**
for PR 18869 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18869
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81356/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81356 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81356/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81356 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81356/testReport)**
for PR 18869 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
@gatorsmile As I said in
https://github.com/apache/spark/pull/18869#discussion_r136706025, we already
have tests in `ExpressionTypeCheckingSuite` to check the predicates don't
support map type. Do
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18869
Could you also add negative test cases for map?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81349/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81349 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81349/testReport)**
for PR 18869 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81348/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81348 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81348/testReport)**
for PR 18869 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81347/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81347 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81347/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81349 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81349/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81348 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81348/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81347 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81347/testReport)**
for PR 18869 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18869
If @viirya were a new contributor, I am fine to merge it.
In contrast, @viirya is experienced and knew the code base pretty well.
Thus, I hope we can make our docs and test coverage
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18869
@gatorsmile, I understand the previously discussed point, the documentation
should be correct, tested well and in details. However, if I observed this
correctly, this argument descriptions have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81311/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81311 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81311/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81311 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81311/testReport)**
for PR 18869 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
Previously `Equal` and `EqualNullSafe` don't state that the type must can
be used in equality comparison. Now added the note.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81306/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81306 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81306/testReport)**
for PR 18869 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
@gatorsmile Right. Isn't too verbose if we describe map is not supported in
each description?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18869
`map` is not supported, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #81306 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81306/testReport)**
for PR 18869 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
@gatorsmile @HyukjinKwon #18818 is merged now. Can this PR go ahead?
As what #18818 did is to allow structs, arrays to be input expression for
predicates, currently looks like we don't have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80439/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80440 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80440/testReport)**
for PR 18869 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80440/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80439 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80439/testReport)**
for PR 18869 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
@gatorsmile Sure. Let's wait after #18818. I'll look at it too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80435/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80435 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80435/testReport)**
for PR 18869 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18869
@viirya Could you hold this PR at first? There is a related PR
https://github.com/apache/spark/pull/18818 that is changing the underlying
semantics. We also need to update the description after
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80440 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80440/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80439 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80439/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80435 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80435/testReport)**
for PR 18869 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
@gatorsmile I've checked the binary predicates in this change. Related test
cases are added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18869
Could you check all of binary predicates you are trying to modify? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80334/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80334 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80334/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80334/testReport)**
for PR 18869 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80332/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80332 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80332/testReport)**
for PR 18869 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80332 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80332/testReport)**
for PR 18869 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
cc @HyukjinKwon @gatorsmile Please help to take a look when you have time.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
72 matches
Mail list logo
