Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18887
I don't think so because checkstyle is for Java only and SBT won't compile
Java code.
I'd kind of love to stop mixing SBT and Maven but that's quite a separate
thing.
I'll put up a
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18887
yea the PR build use SBT. But I think SBT also run checkstyle before?
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18887
Oh, is it because SBT doesn't run checkstyle but Maven does, and SBT runs
the PR builder? This could be my fault, for recently re-enabling checkstyle.
This may be why. Well, for now, I'd at least
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18887
hmmm weird, @srowen any ideas?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/18887
sorry, this is causing a checkstyle error for me while building the project
due to the presence of a finalizer method. I can't understand how this was able
to pass the Jenkins test. Does someone
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18887
LGTM, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82206/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #82206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82206/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #82206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82206/testReport)**
for PR 18887 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18887
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18887
Thanks for your work!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82155/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #82155 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82155/testReport)**
for PR 18887 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82154/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #82154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82154/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #82155 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82155/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #82154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82154/testReport)**
for PR 18887 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18887
nvm, I looked at your previous PRs, the "format" is already defined in
kv-store, as the kv-store can read/write objects directly.
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18887
@cloud-fan not sure I understand your question. What format are you talking
about?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18887
can you also include the format? i.e. how to convert the list information
to key-value entries
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81890/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #81890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81890/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #81890 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81890/testReport)**
for PR 18887 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81697/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #81697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81697/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #81697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81697/testReport)**
for PR 18887 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18887
> What is the migration proposal/guides?
Not sure what you mean. There's no change in behavior by default, so
there's no migration of anything needed.
> What should users do when
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18887
I have the same concern, as @squito said above
https://github.com/apache/spark/pull/18887#pullrequestreview-56700674.
Refactoring the old codes does not seem pointless to me.
To
Github user squito commented on the issue:
https://github.com/apache/spark/pull/18887
I futzed around for a while with trying to keep the old stuff around, and I
realized it really would be quite a mess. The biggest problem is that the old
rest api is just waay too tied into the UI,
Github user squito commented on the issue:
https://github.com/apache/spark/pull/18887
Just to keep others in the loop, Marcelo and I talked about this some
offline. I think this PR itself is fine, but to me this is an important point
in the larger history server project he's doing,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80757/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80757/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80757 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80757/testReport)**
for PR 18887 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18887
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80750/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80750 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80750/testReport)**
for PR 18887 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18887
There's quite a log of unit tests that cover this code; forking would mean
also making those unit tests run against both versions of the code so that no
one breaks anything, and potentially fixing
Github user squito commented on the issue:
https://github.com/apache/spark/pull/18887
>> I feel like we should have one version where the old code is still
available, controlled by a feature flag.
>I'm not sure exactly what you're suggesting. The default behavior is
still,
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18887
> I feel like we should have one version where the old code is still
available, controlled by a feature flag.
I'm not sure exactly what you're suggesting. The default behavior is still,
as
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80750 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80750/testReport)**
for PR 18887 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80701/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80701/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80701/testReport)**
for PR 18887 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80639/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80639/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80639/testReport)**
for PR 18887 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18887
Looks like it is a little big to understand fastly, I need to download the
patch and play it at first :).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18887
hmm... @squito @ajbozarth @jerryshao
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80431/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80431/testReport)**
for PR 18887 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80422/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80422 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80422/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80431/testReport)**
for PR 18887 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80420/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18887
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80420/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80422 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80422/testReport)**
for PR 18887 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18887
**[Test build #80420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80420/testReport)**
for PR 18887 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18887
For context:
* Project link: https://issues.apache.org/jira/browse/SPARK-18085
* Upcoming PRs that build on this code:
https://github.com/vanzin/spark/pulls
---
If your project is set
70 matches
Mail list logo
