Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18900
LGTM Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cloud-fan Any suggestions?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92376/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #92376 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92376/testReport)**
for PR 18900 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #92376 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92376/testReport)**
for PR 18900 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #92374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92374/testReport)**
for PR 18900 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92374/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #92374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92374/testReport)**
for PR 18900 at commit
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cloud-fan totally agree with you, i will try to regenerate output files
for `SQLQueryTestSuite`
---
-
To unsubscribe,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18900
If hive outputs createTime for partitions, we should do it too, right?
---
-
To unsubscribe, e-mail:
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cloud-fan For Hive, `desc extended dbName.table` or `desc extended
dbName.table partition (name=value)` will print `Detailed Table Information` or
`Detailed Partition Information`. Of course,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18900
can you check if hive DESC TABLE output the create time of partitions? We
can regenerate the output files for `SQLQueryTestSuite` if needed.
---
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cloud-fan I found that if we follow code in CatalogTable.toLinkedHashMap,
this patch will break so many test cases in
org.apache.spark.sql.SQLQueryTestSuite (compare *.out files).
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18900
we should also update `CatalogTablePartition.toLinkedHashMap`, following
`CatalogTable.toLinkedHashMap`
Otherwise LGTM
---
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cxzl25 @maropu any suggestionsï¼
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/9/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #9 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/9/testReport)**
for PR 18900 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #9 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/9/testReport)**
for PR 18900 at commit
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cxzl25 I run `build/mvn -Dtest=none
-DwildcardSuites=org.apache.spark.sql.streaming.FlatMapGroupsWithStateSuite
test` in my local PC, output is as follows:
```
Run completed in
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cxzl25 Any suggestions?
```
org.apache.spark.sql.streaming.FlatMapGroupsWithStateSuite.flatMapGroupsWithState
- streaming with processing time timeout
```
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92213/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #92213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92213/testReport)**
for PR 18900 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #92213 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92213/testReport)**
for PR 18900 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18900
Any update?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cxzl25 this PR will break some unit tests, I will fix it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91522/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #91522 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91522/testReport)**
for PR 18900 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #91522 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91522/testReport)**
for PR 18900 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91513/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #91513 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91513/testReport)**
for PR 18900 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #91513 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91513/testReport)**
for PR 18900 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91512/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #91512 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91512/testReport)**
for PR 18900 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #91512 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91512/testReport)**
for PR 18900 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #91511 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91511/testReport)**
for PR 18900 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91511/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #91511 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91511/testReport)**
for PR 18900 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18900
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cxzl25 OK, reopen it
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cxzl25 commented on the issue:
https://github.com/apache/spark/pull/18900
**Modify the partition will lose createTime.**
Reading the hive partitions ignores createTime when converting the
CatalogTablePartition, it will also be lost when modifying partitions.
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
`createTime` is set by HiveMetaStore#initializeAddedPartition
```
private void initializeAddedPartition(Table tbl, PartitionIterator part,
boolean madeDir) throws MetaException {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80558/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #80558 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80558/testReport)**
for PR 18900 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #80558 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80558/testReport)**
for PR 18900 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80528/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #80528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80528/testReport)**
for PR 18900 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18900
**[Test build #80528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80528/testReport)**
for PR 18900 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18900
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cloud-fan Look at this PR again? I just put `createTime` into
CatalogTablePartion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cloud-fan Have a look at this PR again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
My changes is not enough to support `createTime` in CatalogTablePartition,
I will check and re-commit again.
---
If your project is set up for it, you can reply to this email and have your
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18900
+1, similar to `CatalogTable.createTime`, we should have a
`CatalogTablePartition.createTime`
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18900
We should put this in the catalog, shouldn't we?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18900
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user debugger87 commented on the issue:
https://github.com/apache/spark/pull/18900
@cloud-fan could you please help me to review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
68 matches
Mail list logo
