Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
Thanks @holdenk @HyukjinKwon and @viirya !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18982
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
Thanks @holdenk and @HyukjinKwon ! I made a small change so that this can
call the existing `setDefault` method and can avoid adding anything new to the
Scala side. It's a little less clean,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88481 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88481/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88481/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88481 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88481/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1687/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88475/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88475/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88470/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88475/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1684/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88470 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88470/testReport)**
for PR 18982 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
I think I figured out how to use params `setDefault(paramPairs:
ParamPair[_]*)` from python so we won't need to add `setDefaultPair` and the
MiMa exclusion. Let me just do a little more
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1682/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88470/testReport)**
for PR 18982 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18982
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18982
cc @viirya too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88452/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88452 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88452/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1667/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88452/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88369/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88369 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88369/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88369/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1604/
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18982
From my rough reading and based upon what I know, this seems fine.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18982
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18982
So between https://github.com/apache/spark/pull/20410 & this one which path
do we want to go down?
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87228/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #87228 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87228/testReport)**
for PR 18982 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
ping @MLnick @holdenk , seems like this issue popped up a couple times
recently. Can you please take a look here?
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/726/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #87228 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87228/testReport)**
for PR 18982 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
Hi @holdenk , this is updated. Look ok to you?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84035/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #84035 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84035/testReport)**
for PR 18982 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #84035 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84035/testReport)**
for PR 18982 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18982
Can we update this to master?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83691/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #83691 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83691/testReport)**
for PR 18982 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #83691 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83691/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81647/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81647 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81647/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81647 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81647/testReport)**
for PR 18982 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81577/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81577/testReport)**
for PR 18982 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81577 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81577/testReport)**
for PR 18982 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
@holdenk , the error was because I was calling `setDefault` with a separate
`Param` and value. So for something like a `seed` param, the Long value would
get converted to an Int in the exchange
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81574/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81574 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81574/testReport)**
for PR 18982 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81574 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81574/testReport)**
for PR 18982 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18982
Cool, let me know if you want a hand reproing the error.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
Hmmm, I can repeat the error with Python3, I'll look into it tomorrow
---
-
To unsubscribe, e-mail:
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
No problem @holdenk, I updated using `transform()` on the test. See if it
looks ok to you now (pending Jenkins). Thanks!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81487/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81487 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81487/testReport)**
for PR 18982 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81487 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81487/testReport)**
for PR 18982 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
Jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81484/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81484 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81484/testReport)**
for PR 18982 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #81484 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81484/testReport)**
for PR 18982 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18982
@BryanCutler sorry my slowness, responded with a note on the tests. If you
have a chance to update the test and update to master I'd love to try and get
this in.
---
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
Thanks for reviewing @holdenk ! You brought up some good points, let me
know if you prefer me to change them.
---
If your project is set up for it, you can reply to this email and have your
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18982
cc @jkbradley @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80813/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #80813 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80813/testReport)**
for PR 18982 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #80813 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80813/testReport)**
for PR 18982 at commit
89 matches
Mail list logo