Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
ok @squito , thanks for the heads up, I will start on the SPIP process.
---
-
To unsubscribe, e-mail:
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19041
hey @brad-kaiser lemme temper what I said in my previous comments a bit --
I understand what you're doing here now and I think it makes sense, i don't see
any serious design issues. But this is
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Thats great thanks @squito. I will start addressing these comments now.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88899/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88899/testReport)**
for PR 19041 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19041
thanks for the updates @brad-kaiser. I think I understand and don't have
any major concerns. It doesn't seem easy to use the LRU from MemoryStore, so
can set that aside for now
btw as you
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88899/testReport)**
for PR 19041 at commit
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Hey @vanzin, @squito,
I think I've addressed all of your comments. If I missed something or you
have more comments, just let me know.
Thanks
Brad
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88716/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88716 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88716/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88716 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88716/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88673/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88673 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88673/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88673 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88673/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88635/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88635 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88635/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88634/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88634 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88634/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88635 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88635/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88634/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88603/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88603 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88603/testReport)**
for PR 19041 at commit
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
@squito
I've added a line in ExecutorAllocationManager.validateSettings to ensure
that the cached executor timeout is set if cache recovery is enabled. I imagine
most people would
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88603 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88603/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88588/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88588/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88588 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88588/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88550/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88550/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88550 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88550/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88471/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88471 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88471/testReport)**
for PR 19041 at commit
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
@squito
I updated BlockManagerMasterEndpoint.recoverLatestRDDBlock so that we
proactively remove the block from blockManagerInfo when we ask the slave to
remove the block. Thanks for
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #88471 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88471/testReport)**
for PR 19041 at commit
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Hi @squito,
The back and forth communication between CacheRecoveryManager and the
BlockManagerMasterEndpoint is so that we always have an up to date view of what
executors are
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19041
Thanks @brad-kaiser -- want to re-iterate my comment from Feb 2nd, I think
that is really the most important part to address before getting into the
details of the current implementation:
>
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Hi @squito , thank you for your feedback! I have not been able to work on
this PR lately, but I will get back to it soon. @vanzin I will also address the
rest of your feedback and fix those
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19041
@brad-kaiser have you had time to look at Imran's feedback? Your patch also
has conflicts now...
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87142/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #87142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87142/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87138/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #87138 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87138/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87137/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #87137 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87137/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #87142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87142/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #87138 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87138/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #87137 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87137/testReport)**
for PR 19041 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19041
Thought some more about the race between `RemoveBlock` getting sent back
from the executor vs when the `CacheRecoveryManager` tries to replicate the
next block -- actually why is there the
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Thanks, I will address these shortly
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Hey @vanzin, I just wanted to follow up and see if you've had a chance to
look at this. Thanks!
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Lol, no worries. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19041
> Is there anything else you need for this PR?
An extra day on my work week...
---
-
To unsubscribe, e-mail:
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Hey @vanzin just wanted to check in on this. Is there anything else you
need for this PR? Thanks!
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85070/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #85070 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85070/testReport)**
for PR 19041 at commit
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Thanks @vanzin . I've addressed all the comments. Please let me know if
there is anything else you would like me to change.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #85070 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85070/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84935/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84935/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84935 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84935/testReport)**
for PR 19041 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19041
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84875/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84875 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84875/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84875 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84875/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84782/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84782 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84782/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84777/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84777 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84777/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84782 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84782/testReport)**
for PR 19041 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84777 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84777/testReport)**
for PR 19041 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84585/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84585 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84585/testReport)**
for PR 19041 at commit
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Thanks @vanzin I fixed the javadoc bug and I will address these issues.
I spent some time investigating an issue that turned out to be SPARK-22618.
In the process I rewrote a lot of
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19041
**[Test build #84585 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84585/testReport)**
for PR 19041 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19041
Can you fix the javadoc issue?
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder@2/core/target/java/org/apache/spark/CacheRecoveryManager.java:80:
error: invalid use of
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19041
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 132 matches
Mail list logo
