Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19077
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87212/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87212/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87212/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/710/
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/19077
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19077
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19077
seems jenkins is very tired now, let's try later :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87190/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87192/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87190 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87190/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87192 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87192/testReport)**
for PR 19077 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19077
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87183/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87183/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87192 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87192/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/692/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/690/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87190 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87190/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/683/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87183/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87106/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87106 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87106/testReport)**
for PR 19077 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19077
LGTM, we can also update L71 `long[] array = new long[(int) ((size + 7) /
8)];`, to use the `alignedSize`
---
-
To
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/19077
I have updated this PR, just a little bit of improvement, please help
review it again,thanks @jiangxb1987 @cloud-fan
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #87106 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87106/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/626/
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19077
The idea LGTM, but I think we can simplify the implementation to allow the
memory allocator to return a larger memory than requested.
---
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19077
ping @cloud-fan shall we continue with this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83715/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83715/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83715/testReport)**
for PR 19077 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19077
According to [this
material](http://s3-eu-west-1.amazonaws.com/presentations2013/10_presentation.pdf#pages=42),
`Unsafe.allocateMemory` uses 8-byte boundary.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83695/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83695/testReport)**
for PR 19077 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19077
What about the unsafe allocation Spark does? Is it also better to use
8-byte boundaries?
---
-
To unsubscribe, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19077
@cloud-fan IIUC, this PR does not change alignment policy for page
allocation. Alignment policy still depends on JVM. This PR changes reuse policy
in memory pool.
If you are asking about
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83695/testReport)**
for PR 19077 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19077
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83686/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83686/testReport)**
for PR 19077 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19077
shall we always do word alignment for page allocation? cc @kiszk too
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83686/testReport)**
for PR 19077 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19077
cc @cloud-fan for review
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19077
ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19077
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83102/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83102 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83102/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83102 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83102/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83068/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83068 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83068/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #83068 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83068/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82668/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #82668 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82668/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #82668 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82668/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #82666 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82666/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82666/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #82666 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82666/testReport)**
for PR 19077 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19077
gentle ping @jerryshao for review
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81508/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81508 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81508/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81508 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81508/testReport)**
for PR 19077 at commit
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/19077
restest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81492/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81492/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81491/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81491 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81491/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81492/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81491 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81491/testReport)**
for PR 19077 at commit
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/19077
@jerryshao @JoshRosen yes, it would not generally be arbitrary sized
allocations. Basically, we allocate memory in multiples of 4 or 8 bytesï¼even
so, I think this change is also beneficial .
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/19077
Just curious: do you know where are we allocating these close-in-size
chunks of memory? I understand the motivation, but just curious to know what's
causing this pattern. I think the original
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19077
This PR generally looks fine to me, my concern is that will this change
bring in subtle impact on the code which leverage it.
CC @JoshRosen to take a review.
---
If your project is set
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81273/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81273 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81273/testReport)**
for PR 19077 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81272/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81272/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81273 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81273/testReport)**
for PR 19077 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19077
**[Test build #81272 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81272/testReport)**
for PR 19077 at commit
1 - 100 of 112 matches
Mail list logo
