Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
@gatorsmile
OK and thanks a lot for review :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19086
Thanks for working on it! @jinxing64
Our current behavior is based on what the other traditional DBMS systems
do. Moving tables across different database is rare. For example, DB2 and
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
@gatorsmile
I feel sorry if this pr breaks rules of current code. But I think the
function is a good(convenient for user) one. In our warehouse, there hundreds
ETLs are using this function
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
I'm from Meituan, a Chinese company
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19086
If we follow what our current way, rename becomes a special case. All the
other commands are following different resolution ways.
Just curious which company are your from? I am trying to
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
It's not ok to follow Spark current behavior?(It will be different from
Hive)
I make this pr because we are migrating from Hive to Spark and lots of our
users are using this function.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19086
After more discussion with others, this behavior change really bothers us.
Both changes do not sound good to us. Where is the requirement from?
---
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
@gatorsmile More comments on this ?
Regarding the behavior change, should we follow Spark previous behavior or
follow Hive? I'm ok with both.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81374/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81374/testReport)**
for PR 19086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81374/testReport)**
for PR 19086 at commit
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
Sure, current behavior is hive behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19086
Please hold it. It means it is a behavior change. Let me consider it more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
yes, correct
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19086
> use db2;
> alter table db1.t2 rename to t1;
After this PR, it is renamed to `db2.t1`, right?
Before this PR, it is renamed to `db1.t1`, right?
---
If your project is set
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81370/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81370/testReport)**
for PR 19086 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81370/testReport)**
for PR 19086 at commit
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
@gatorsmile
I updated, let me known if there's still comments not resolved.
Thanks again for review.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81361/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81361/testReport)**
for PR 19086 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81361/testReport)**
for PR 19086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81277/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81277/testReport)**
for PR 19086 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81277/testReport)**
for PR 19086 at commit
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
Thanks, I will refine soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19086
Test cases are missing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/19086
@gatorsmile
Thanks for taking time look at this. I updated description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81260/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81260 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81260/testReport)**
for PR 19086 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19086
Could you post the Hive compatibility in the PR description? Also please
post the outputs from Hive command lines? Thanks!
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19086
**[Test build #81260 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81260/testReport)**
for PR 19086 at commit
37 matches
Mail list logo
