Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
Thanks, @HyukjinKwon @jsnowacki @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
Build started:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19090
Tested this, looks good to me
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
@felixcheung, this one LGTM as I checked what I could all and quite
confident; however, will leave this open for few days more considering
importance. Let me please cc you here to double check
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
Thanks for reviewing @jsnowacki, let me try to take a final look. I also
checked what I could all but let me double check. Just want to be careful as
it's the entry point.
---
Github user jsnowacki commented on the issue:
https://github.com/apache/spark/pull/19090
I think the comments are fine and sufficiently explain extra quotes
existence.
---
-
To unsubscribe, e-mail:
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
@jsnowacki I have already add comments to explain the quotes, could you
help me review the comments? Thanks.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19090
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82387/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19090
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19090
**[Test build #82387 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82387/testReport)**
for PR 19090 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19090
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19090
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82386/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19090
**[Test build #82386 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82386/testReport)**
for PR 19090 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19090
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19090
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82385/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19090
**[Test build #82385 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82385/testReport)**
for PR 19090 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19090
**[Test build #82387 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82387/testReport)**
for PR 19090 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19090
**[Test build #82386 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82386/testReport)**
for PR 19090 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19090
**[Test build #82385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82385/testReport)**
for PR 19090 at commit
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
@jsnowacki Thanks for reviewing this PR! There are some situations people
cannot omit the quotes, such as multiple parameters of
"--driver-java-options". For example: [passing multiple -D
Github user jsnowacki commented on the issue:
https://github.com/apache/spark/pull/19090
I've also tested the solution and, indeed, it works as intended, though, I
never seen a complaint about this, as people tend to omit quotes, not the other
way around. Also, the changes looks
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
@jsnowacki, would you mind if I ask double check this PR when you have some
time?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
Thanks for thorough testing. Yea, looks fine. Will take a look few times
more by myself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
I design two groups test cases:
- Test cases about windows command scripts options
- Examples in Spark Document
All these test cases works well.
## Test cases
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
ok, I will give more test cases later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
I believe that would make this PR much more persuasive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user minixalpha commented on the issue:
https://github.com/apache/spark/pull/19090
@HyukjinKwon Thanks for your review! Should I provide more test cases to
cover the potential corner cases?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19090
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81305/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19090
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19090
**[Test build #81305 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81305/testReport)**
for PR 19090 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
Looks ok given the examples & syntax - https://ss64.com/nt/cmd.html and
https://technet.microsoft.com/en-us/library/cc771320(v=ws.11).aspx and my
manual tests.
I think here is the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19090
**[Test build #81305 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81305/testReport)**
for PR 19090 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19090
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
35 matches
Mail list logo
