Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19180
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81831/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81831 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81831/testReport)**
for PR 19180 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81831 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81831/testReport)**
for PR 19180 at commit
Github user original-brownbear commented on the issue:
https://github.com/apache/spark/pull/19180
@srowen alright then, switched to the JDK comparison left the rest as is :)
---
-
To unsubscribe, e-mail:
Github user original-brownbear commented on the issue:
https://github.com/apache/spark/pull/19180
@srowen benchmarked this some more on a quiet workstation to make sure and:
this version still wins all categories and even beats the current version
in `master` if at least 2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81796/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81796/testReport)**
for PR 19180 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81794/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81794 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81794/testReport)**
for PR 19180 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81796/testReport)**
for PR 19180 at commit
Github user original-brownbear commented on the issue:
https://github.com/apache/spark/pull/19180
@srowen updated, we don't even need to break out via `wordMax > 0`, we can
just get the offsets from `other` and save one level of indirect in the second
loop by using
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81794/testReport)**
for PR 19180 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19180
Yeah it would be great if it were strictly faster. For < 7 bytes, the new
loop doesn't execute, so it doesn't matter, and it just proceeds with the old
loop, which should be the same. The only
Github user original-brownbear commented on the issue:
https://github.com/apache/spark/pull/19180
@srowen played a little with
https://github.com/original-brownbear/spark/blob/string-compareto-benchmark-both/core/src/test/scala/org/apache/spark/benchmarks/UTF8StringBenchmark.scala
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19180
CC @davies
By the way do you have any measurements that show the speed up? I imagine
it's faster, but mostly curious if it's still a win for short strings.
---
Github user original-brownbear commented on the issue:
https://github.com/apache/spark/pull/19180
@srowen I think we have that already here
https://github.com/apache/spark/blob/master/common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java#L103
`("ä½
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81692/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81692 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81692/testReport)**
for PR 19180 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19180
**[Test build #81692 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81692/testReport)**
for PR 19180 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19180
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user original-brownbear commented on the issue:
https://github.com/apache/spark/pull/19180
@srowen thanks, all comments addressed I think :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user original-brownbear commented on the issue:
https://github.com/apache/spark/pull/19180
@srowen got a sec to take a look at this one? :) (should be a quick one)
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19180
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
28 matches
Mail list logo
