Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19208
Awesome, thanks for the updates and for checking backwards compatibility!
LGTM
Merging with master
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83834/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83834 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83834/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83835/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83835 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83835/testReport)**
for PR 19208 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83835 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83835/testReport)**
for PR 19208 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83834 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83834/testReport)**
for PR 19208 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83824 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83824/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83824/
Test FAILed.
---
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
I manually tested backwards compatibility and it works fine. I paste the
test code for `CrossValidator` here.
Run following code in spark-2.2 shell first:
```
import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83824 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83824/testReport)**
for PR 19208 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83823 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83823/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83823/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83823 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83823/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83534/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83534 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83534/testReport)**
for PR 19208 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83534 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83534/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83530 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83530/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83530/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83530 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83530/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83469/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83469/testReport)**
for PR 19208 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83469/testReport)**
for PR 19208 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19208
Done with review. I mainly review CrossValidator since some comments will
apply to TrainValidationSplit as well. Thanks for the PR!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83393/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83393/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #83393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83393/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83388/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
ping @jkbradley Comments all addressed! Pls take a look again. Thanks!
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #3972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3972/testReport)**
for PR 19208 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19208
taking a look...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #3972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3972/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82246/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #82246 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82246/testReport)**
for PR 19208 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
cc @smurching code updated, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #82246 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82246/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #82233 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82233/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82233/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #82233 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82233/testReport)**
for PR 19208 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
I will update this PR after #19350 get merged. We need to address another
issue first. Thanks!
---
-
To unsubscribe,
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
@smurching I will update this PR after #19278 merged. Because now this PR
depend on that one. Thanks!
---
-
To
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
@smurching Thanks! I will update later. And note that I will separate part
of this PR to a new PR (the separated part will be a bugfix for #16774 )
---
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/19208
It's OK to me to include the "dump model to disk"
https://github.com/apache/spark/pull/18313 in this or other PR (or not).
After reading the discussion, I feel it's an overkill to support a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81772/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #81772 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81772/testReport)**
for PR 19208 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #81772 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81772/testReport)**
for PR 19208 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81767/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #81767 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81767/testReport)**
for PR 19208 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #81767 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81767/testReport)**
for PR 19208 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
@jkbradley I split this PR, removed the code for "dump models to disk", so
the PR will be smaller and easier to review. When this PR merged, I will create
follow-up PR for "dump models to
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19208
Synced offline: I hadn't looked carefully and seen the 2 issues had been
merged. @WeichenXu123 said he will split the work in 2, adding one parameter
first.
---
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
oh...sorry for that, I integrate @hhbyyh's old PR into this new one,
because I found the code "dump models to disk" and "collect models" seem to be
cohesive and split them will cause some
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19208
CC @hhbyyh and @MLnick Does this look reasonable to you?
And @hhbyyh would you want to split off a new JIRA for your original
solution of adding an option to dump models to disk? Then
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #81686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81686/testReport)**
for PR 19208 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81686/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #81686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81686/testReport)**
for PR 19208 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19208
cc @jkbradley
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19208
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81685/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #81685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81685/testReport)**
for PR 19208 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19208
**[Test build #81685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81685/testReport)**
for PR 19208 at commit
77 matches
Mail list logo
