Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19216
Yeah, as it doesn't cause any trouble now, I don't bother to re-open it.
Btw, another bad to reply on the optimization rule to produce correct
constraints is the extra cost introduced by
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19216
Yes, I agree. But constraints is used in filter inference only, and it
works now. The code changes in this PR make the logic complex.
I think we should make the logic simpler, if we decide
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19216
I'm thinking more about this.
Actually I think we shouldn't rely on an optimization rule to produce
correct constraints. If there is a logical plan other than `Filter` that can
get its
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19216
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81749/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19216
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19216
**[Test build #81749 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81749/testReport)**
for PR 19216 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19216
@gengliangwang I think it should be safe. Let me close this now. Thanks.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19216
@gengliangwang Yeah, I see. `InferFiltersFromConstraints` will construct
new `Filter` from inferred constraints and `c > 1` will be inferred in the new
`Filter`. I'm trying to see if there can be an
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19216
Thanks.
I run the test case with the rule "InferFiltersFromConstraints", the result
has `c > 5`.
The rule will be executed multiple times.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19216
**[Test build #81749 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81749/testReport)**
for PR 19216 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19216
@gengliangwang How about the modified one in the description?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19216
@gengliangwang Thanks. I'm modifying the test case.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19216
```
a === b && a === 1 && b === 5
```
The result is always False.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19216
@gengliangwang Sorry, what the meaning it should be optimized to False?
---
-
To unsubscribe, e-mail:
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19216
Hi @viirya ,
could you find a better example?
The one in the description/test case should be optimized to False.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19216
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19216
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81720/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19216
**[Test build #81720 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81720/testReport)**
for PR 19216 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19216
**[Test build #81720 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81720/testReport)**
for PR 19216 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19216
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19216
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81711/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19216
**[Test build #81711 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81711/testReport)**
for PR 19216 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19216
**[Test build #81711 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81711/testReport)**
for PR 19216 at commit
23 matches
Mail list logo
