Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/19234
I think that porting changes from Python 3.6 give us too complicated code.
I'm closing it.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19234
@maver1ck, if you'd like to leave it as is, I think we should better close
it.
---
-
To unsubscribe, e-mail:
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/19234
It was introduced with this PEP.
https://www.python.org/dev/peps/pep-0495/
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19234
Hm, BTW, do we handle
https://github.com/python/cpython/blob/018d353c1c8c87767d2335cd884017c2ce12e045/Lib/datetime.py#L1443-L1455:
```python
if tz is None:
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/19234
OK. It passed all tests, so let merge it
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/19234
I'm asking because such a code is 2x faster than my solution
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/19234
Any idea why we're not using
`datetime.datetime.fromtimestamp(ts / 10.)` ?
There is a comment about overflow. But if it exists ?
---
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19234
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
