Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19249
We can split two `needConversion` for key and value only and save key
conversion or value conversion call though?
---
-
To
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/19249
@ueshin
I think that for Maptype this is not a solution because every key / value
of MapType is the same type so we need conversion for all entries or for nothing
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19249
Thanks for double checking @ueshin.
Yes, I noticed that too while reviewing it. I just decided to merge it as
is because I am quite sure of this one given struct type is the root type
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19249
A late LGTM. Btw, can we use the same idea for `MapType`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19249
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19249
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19249
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81854/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19249
**[Test build #81854 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81854/testReport)**
for PR 19249 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19249
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19249
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81853/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19249
**[Test build #81853 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81853/testReport)**
for PR 19249 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19249
**[Test build #81854 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81854/testReport)**
for PR 19249 at commit
Github user maver1ck commented on the issue:
https://github.com/apache/spark/pull/19249
Done.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19249
LGTM too but hey @maver1ck could you add some comments around the codes and
move the worst case benchmarks into the PR description? I guess this wouldn't
be too demanding.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19249
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19249
**[Test build #81853 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81853/testReport)**
for PR 19249 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19249
**[Test build #81852 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81852/testReport)**
for PR 19249 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19249
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81852/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19249
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19249
**[Test build #81852 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81852/testReport)**
for PR 19249 at commit
20 matches
Mail list logo
