Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/19257
Created https://github.com/apache/spark/pull/20041 for addressing the
follow-up comments by @gatorsmile
---
-
To
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19257
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19257
LGTM except a few style comments. We can merge it and fix it in the
follow-up PR. Thanks!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19257
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84806/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19257
**[Test build #84806 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84806/testReport)**
for PR 19257 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19257
**[Test build #84806 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84806/testReport)**
for PR 19257 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19257
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19257
Gentle ping~
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ash211 commented on the issue:
https://github.com/apache/spark/pull/19257
@cloud-fan @gatorsmile any more changes needed on this PR before merging?
I don't see any un-addressed comments left.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84232/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19257
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19257
**[Test build #84232 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84232/testReport)**
for PR 19257 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19257
**[Test build #84232 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84232/testReport)**
for PR 19257 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19257
Thank you for the decision, @cloud-fan . It's great to see the progress on
this!
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19257
After some more thoughts, I think the best choice is to do planning bottom
up. That requires a lot of refactoring and I'm fine to merge this workaround
first.
LGTM except one minor
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19257
@felixcheung Don't worry, the bug only exists in the master branch, so it
won't block the 2.2.1 release. I have corrected the JIRA ticket's affected
version to 2.3 . Also I'm looking into this
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19257
how is this coming? it will be good to fix this in 2.2?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19257
Thank you for your update, @tejasapatil .
@cloud-fan and @gatorsmile . Could you give us some direction?
---
-
To
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/19257
Or we could move forward with the current approach and defer the
refactoring around how shuffles are added in planning phase.
---
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/19257
@dongjoon-hyun : It will take me time to get back to this. Having said that
, its not ideal to have master is bad state. How about disabling the rule by
default (using a config) ?
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19257
Hi, All.
Master branch still has this problem. Can we proceed this?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19257
> We need to know the exact partitioning of the children which dummy nodes
won't give
We only add the dummy shuffle node when it's necessary, e.g.
```
hash-join
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/19257
By "placeholder shuffle nodes" you mean dummy ones ? We need to know the
exact partitioning of the children which dummy nodes won't give (maybe I didn't
get what you meant). My fear is that
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19257
Maybe we need to rethink about the planning phase for adding shuffles. How
about we add a placeholder for shuffle node and then replace the placeholder
with actual shuffle node in
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/19257
cc @cloud-fan @gatorsmile @sameeragarwal for review
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19257
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81847/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19257
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19257
**[Test build #81847 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81847/testReport)**
for PR 19257 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19257
**[Test build #81847 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81847/testReport)**
for PR 19257 at commit
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/19257
Jenkins test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
31 matches
Mail list logo
