Github user tdas commented on the issue:
https://github.com/apache/spark/pull/19271
@brkyvz @zsxwing thank you for reviewing. I have merged it to master!
---
-
To unsubscribe, e-mail:
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/19271
@brkyvz
1. we can add this test later.
2. as discussed offline, this method is only to generate the expression and
is not responsible for checking whether the expression has watermarks.
Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/19271
LGTM: Would love to see the following things a bit more buttoned up in a
follow up PR:
1. Tests on join + aggregation and aggregation + join
2. A better, safer, more understandable
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82011/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #82011 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82011/testReport)**
for PR 19271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82010/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #82010 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82010/testReport)**
for PR 19271 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/19271
LGTM pending tests
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #82011 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82011/testReport)**
for PR 19271 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #82010 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82010/testReport)**
for PR 19271 at commit
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/19271
@brkyvz I dont splitting this PR now into 2 PRs is a good idea. The reason
I did this together is that both features are intricately tied together and the
watermark stuff required completely
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82004/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #82004 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82004/testReport)**
for PR 19271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82002/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #82002 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82002/testReport)**
for PR 19271 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #82004 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82004/testReport)**
for PR 19271 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #82002 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82002/testReport)**
for PR 19271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81986/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81986 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81986/testReport)**
for PR 19271 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81986 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81986/testReport)**
for PR 19271 at commit
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/19271
jenkins retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81972/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81972/testReport)**
for PR 19271 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81972/testReport)**
for PR 19271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81958/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81958 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81958/testReport)**
for PR 19271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81957/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81957 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81957/testReport)**
for PR 19271 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81958 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81958/testReport)**
for PR 19271 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81957 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81957/testReport)**
for PR 19271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81913/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81913 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81913/testReport)**
for PR 19271 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81913 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81913/testReport)**
for PR 19271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81907/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81907/testReport)**
for PR 19271 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81907/testReport)**
for PR 19271 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81900/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19271
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19271
**[Test build #81900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81900/testReport)**
for PR 19271 at commit
49 matches
Mail list logo
