Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19281
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19281
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19281
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19281
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82054/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19281
**[Test build #82054 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82054/testReport)**
for PR 19281 at commit
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/19281
Thank you, @wzhfy, very much for the comments! I have made corresponding
changes in my latest commit.
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19281
**[Test build #82054 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82054/testReport)**
for PR 19281 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19281
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81980/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19281
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19281
**[Test build #81980 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81980/testReport)**
for PR 19281 at commit
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/19281
Thank you very much for the feedback, @tejasapatil, @gatorsmile! All the
suggestions/comments have been addressed by my latest check-in.
---
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/19281
@cloud-fan Please refer to
https://issues.apache.org/jira/browse/SPARK-18591. The plan is to apply the
optimization during physical planning stage, and specifically, when creating
Aggregate
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19281
**[Test build #81980 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81980/testReport)**
for PR 19281 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19281
> So we ended up not getting the correct outputOrdering during physical
planning stage before Sort nodes are added to the children.
What's the harm of this? I think only
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19281
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81966/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19281
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19281
**[Test build #81966 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81966/testReport)**
for PR 19281 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19281
**[Test build #81966 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81966/testReport)**
for PR 19281 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19281
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/19281
bq. This is not accurate. It depends on the length of required ordering and
the length of child ordering.
You are right. I did it right in the code but made a mistake in the
description
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19281
> If the childOutputOrdering satisfies (is a superset of) the required
child ordering => childOutputOrdering
This is not accurate. It depends on the length of required ordering and the
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19281
@gatorsmile @cloud-fan could you trigger tests if it is worth fixing?
Thanks.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19281
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
23 matches
Mail list logo
