Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
Ah, thank you @shaneknapp. The command below:
```
Rscript -e "devtools::install_github('jimhester/lintr@5431140')"
```
should upgrades `lintr` to the desired version
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/19290
hey all, i'm here. was out sick for the past few days and trying to get
caught up. sorry about that!
so... what version of lintr do we need to put on the workers?
On Fri,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82312/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82312 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82312/testReport)**
for PR 19290 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82312 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82312/testReport)**
for PR 19290 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82308/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82308 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82308/testReport)**
for PR 19290 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
I just double checked the newer lintr, lintr@5431140, passes on the top of
the master with the current change.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82308 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82308/testReport)**
for PR 19290 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
Oh! but if we upgrade it first, many builds in PRs should be broken due to
this check failure. Probably, let me revert the script first to not upgrade it
in order to unblock this.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
Let me revert "... || packageVersion("lintr") != "1.0.1.9000" this
condition back so that it does not try to upgrade it.
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19290
hmm, perhaps open a ticket to ask shane to update Jenkins to this commit
checksum manually?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82236/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82236 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82236/testReport)**
for PR 19290 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82236 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82236/testReport)**
for PR 19290 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
For more context, I believe `lintr` was initially installed in
https://github.com/apache/spark/commit/004f57374b98c4df32d9f1e19221f68e92639a49.
Upgrade to jimhester/lintr@a769c0b was proposed
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
Do you maybe have some worries about this? If that worry is quite crucial,
I think we could also consider an option, not upgrading this, leaving
`lint-r.R` script as was, and only fixing the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
@shaneknapp Sure, it was my bad. I will be careful next time.
It is required to fix an actual issue in order to to detect R codes that do
not follow project's R style.
---
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/19290
@HyukjinKwon -- you will absolutely not have builds install packages on the
build system. this is a really bad idea.
is this absolutely required, or just to fix a warning in the build
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82129/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82129 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82129/testReport)**
for PR 19290 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82128/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82128 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82128/testReport)**
for PR 19290 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
Hi @shaneknapp. I am sorry but it's me again ...
Here, this PR tries to upgrade an R package,
[lintr](https://github.com/jimhester/lintr) for static Code analysis for R,
which is ran
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
Ugh.. it failed to install due to permission issue ...
```
Downloading GitHub repo jimhester/lintr@5431140
from URL https://api.github.com/repos/jimhester/lintr/zipball/5431140
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82129 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82129/testReport)**
for PR 19290 at commit
32 matches
Mail list logo
