Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19295
Sorry, we do not expect users to add rules before our internal optimizer
rules finish, as I explained above. To avoid the potential issues, I suggest to
close it.
---
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19295
I pushed a new commit that addresses @wzhfy review comments..
---
-
To unsubscribe, e-mail:
Github user sathiyapk commented on the issue:
https://github.com/apache/spark/pull/19295
@gatorsmile thanks for your comments. Here are my thoughts, thanks for
correcting me if i'm wrong. (sorry for the big comment though :))
1. This PR don't change any existing API, it adds a new
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19295
I do not think we should do it. The extra pre-optimizer rules can easily
break our existing optimizer rules. Adding post optimizer rules should be
enough for 99% cases.
---
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19295
ping @cloud-fan @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19295
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19295
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19295
why can't user just use `preOptimizationBatches`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19295
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
