Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19300
or find and fix more typos ;)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19300
I'd help review other PRs and leave a comment when someone fixes some codes
around it rather than proposing it alone, or you can buffer it in your local
and flush it.
---
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/19300
if we find some mistakes likes this , shouldn't we to report it at first?
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19300
@HyukjinKwon will make this change in another PR. We do need to push back
on tiny PRs. It's a problem because some people are actually incentivized based
on number of patches and it costs the
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/19300
@cloud-fan @gatorsmile Could you please help to review this and merge it
to master? Thanks.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19300
I can give you many reasons - reviewing cost, build cost (including
retriggering Jenkins build when failed unexpectedly, for example, -9 signal),
potentially making conflicts / rebasing in
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19300
I don't think we should ever encourage to fix a single typo. It doesn't
look making any harm to the context or contents really.
---
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/19300
> or don't bother and close this
I have not found other typos and sorry i'm not agree with you. Since this
spelling mistake affects the API doc in official website, we should fix it of
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19300
I am fixing some codes around here -
https://github.com/apache/spark/pull/19290/files#diff-d9f92e07db6424e2527a7f9d7caa9013R328.
If this one is only the one, let me fold this into mine.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19300
Please review and fix typos in a whole batch of code, or don't bother and
close this
---
-
To unsubscribe, e-mail:
10 matches
Mail list logo
