Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19320
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82103/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19320
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19320
**[Test build #82103 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82103/testReport)**
for PR 19320 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19320
**[Test build #82103 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82103/testReport)**
for PR 19320 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19320
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/19320
In JDBC / ODBC Server page, 'job ids' are separated by braces, as shown
below:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19320
I agree with making things consistent. The question is, I guess, what the
JDBC/ODBC page does. You can match that.
---
-
To
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/19320
Do you agree with my PR or against my PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/19320
In JDBC / ODBC Server page.There are no other places yet.
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19320
I see, you're saying the display of a bunch of job IDs is like "[1] [2]
[3]" elsewhere? consistency is the most important thing IMHO. I'd just match
whatever a similar column does elsewhere.
---
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/19320
Do you want to get rid of braces?
Then the JDBC / ODBC Server page also needs to remove the braces. But I
think there is a better distinction between brackets This is the job id.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19320
Why braces? just seems like noise
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/19320
I have fixed it.
![7](https://user-images.githubusercontent.com/26266482/30735570-1aae290a-9fb2-11e7-9ec2-fdf21ea44804.png)
---
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/19320
@HyukjinKwon @jerryshao @ajbozarth
Help to review the code, thanks.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19320
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
16 matches
Mail list logo