Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
Seems there is a conflict while backporting to branch-2.2. @jsnowacki, mind
opening a backporting PR to branch-2.2 please?
I think this is important for many Windows users and I guess
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
Build started: [SparkR] `ALL`
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84119/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84119/testReport)**
for PR 19370 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84119/testReport)**
for PR 19370 at commit
Github user jsnowacki commented on the issue:
https://github.com/apache/spark/pull/19370
Thanks for looking into it again. I've followed your suggestions and
updated PR. It also seems to work for me now.
---
-
To
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
In `if not exist "%FIND_SPARK_HOME_PYTHON_SCRIPT%" (`, I switched the
condition to be matched with
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
I suggest this:
```cmd
rem Path to Python script finding SPARK_HOME
set FIND_SPARK_HOME_PYTHON_SCRIPT=%~dp0find_spark_home.py
rem Default to standard python interpreter
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84077/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84077 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84077/testReport)**
for PR 19370 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84077 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84077/testReport)**
for PR 19370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84068 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84068/testReport)**
for PR 19370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84068/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84068 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84068/testReport)**
for PR 19370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84038/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84038/testReport)**
for PR 19370 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84038/testReport)**
for PR 19370 at commit
Github user jsnowacki commented on the issue:
https://github.com/apache/spark/pull/19370
I've added this check using `where`; it is at least some protection against
missing python with some more meaningful information returned.
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19370
I think the concern is we are adding python dependency for even non python
use cases.
We could track handling missing python better separately. My concerns is
python is not a standard
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
Yup, +1 for going ahead with branch-2.2.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84004/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84004 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84004/testReport)**
for PR 19370 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84004 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84004/testReport)**
for PR 19370 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
Will take a final look tomorrow.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83809/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #83809 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83809/testReport)**
for PR 19370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83806/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #83806 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83806/testReport)**
for PR 19370 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #83809 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83809/testReport)**
for PR 19370 at commit
Github user jsnowacki commented on the issue:
https://github.com/apache/spark/pull/19370
I've corrected the code with the above comments and linked this PR to
[SPARK-22495](https://issues.apache.org/jira/browse/SPARK-22495). The only
thing I could think of regarding solving the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #83806 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83806/testReport)**
for PR 19370 at commit
39 matches
Mail list logo
