Github user nzw0301 commented on the issue:
https://github.com/apache/spark/pull/19372
Thank you for your kindful reviews!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19372
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19372
**[Test build #3943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3943/testReport)**
for PR 19372 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19372
**[Test build #3943 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3943/testReport)**
for PR 19372 at commit
Github user nzw0301 commented on the issue:
https://github.com/apache/spark/pull/19372
I updated the results of word2vec example based on this PR in the first
comment.
---
-
To unsubscribe, e-mail:
Github user nzw0301 commented on the issue:
https://github.com/apache/spark/pull/19372
Thank you for your reviews, @LowikC.
Like this?
```scala
val totalWordsCounts = numIterations * trainWordsCount + 1
val numWordsProcessedInPreviousIterations = (k - 1) *
Github user LowikC commented on the issue:
https://github.com/apache/spark/pull/19372
Looks good to me.
Maybe @nzw0301 could split the formula for readability?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19372
**[Test build #3939 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3939/testReport)**
for PR 19372 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19372
**[Test build #3939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3939/testReport)**
for PR 19372 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19372
What do you think @LowikC ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user nzw0301 commented on the issue:
https://github.com/apache/spark/pull/19372
Thank you for your comment, @LowikC.
You are right, my PR code is incorrect.
Correct update formula is
```scala
alpha = learningRate *
(1 - numPartitions *
Github user LowikC commented on the issue:
https://github.com/apache/spark/pull/19372
I think the PR is incorrect:
- the original C code decreases the learning rate linearly from
`starting_alpha` to 0, across all iterations
new_alpha = `starting_alpha` * (1 - progress),
12 matches
Mail list logo
