Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19396
Sorry I didn't notice it, will double-check next time.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19396
we should update PR description too, but it's too late now...
---
-
To unsubscribe, e-mail:
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19396
OK, let me merge to master branch.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19396
I'm OK with the current changes.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19396
The change itself looks good to me, WDYT @jerryshao @cloud-fan ?
---
-
To unsubscribe, e-mail:
Github user devaraj-kavali commented on the issue:
https://github.com/apache/spark/pull/19396
@jiangxb1987 Thanks for the comment, I made the change which throws
exception and exits the worker.
---
-
To
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19396
IMO we should throw a new Exception in order to fail fast, it may cause
some weird issues running with an ESS that you can't connect to.
---
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19396
Sorry for the late response. I understand you purpose now. I think such
behavior discrepancy is not a big problem.
I guess the reason why NM still run with exception is that NM doesn't
Github user devaraj-kavali commented on the issue:
https://github.com/apache/spark/pull/19396
@jerryshao Please let me know if you don't convince with the above comment,
I can make the changes to PR to make Worker do down on external shuffle service
start failure.
---
Github user devaraj-kavali commented on the issue:
https://github.com/apache/spark/pull/19396
Thanks @jerryshao for the comment.
> IMO I think it might be better to throw an exception instead of not
starting shuffle service. Since user want to use external shuffle explicitly,
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19396
IMO I think it might be better to throw an exception instead of shifting to
another shuffle. Since user want to use external shuffle explicitly, letting
user to know the issues and fix the issue
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19396
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
12 matches
Mail list logo