Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19468
Thanks everyone and congrats!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/19468
Done, created subtasks.
Thanks everyone for helping review this PR!
---
-
To unsubscribe, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19468
For future pull requests, can you create subtasks under
https://issues.apache.org/jira/browse/SPARK-18278 ?
---
-
To unsubscribe,
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19468
Thanks - merging in master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19468
LGTM, thanks for the awesome work!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/19468
Thanks for the changes, and all the great work !
The pr LGTM for merge.
@rxin and @felixcheung have already +1'ed it.
We can leave it open for a day or so in case others want to do a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84265/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84265 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84265/testReport)**
for PR 19468 at commit
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/19468
@felixcheung @mridulm All the comments have been addressed. Is this good to
merge?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84265 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84265/testReport)**
for PR 19468 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19468
I think the other cases, mesos, yarn/docker are quite different as they are
one of the possible environment/setup, whereas in this case there is no other
alternative - docker image must be
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19468
I see the latest changes are backported back to the fork - thanks! it's
useful to do since I think we get more comprehensive test coverage there, for
now.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84234/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84234 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84234/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84233/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84233 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84233/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84230/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84230 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84230/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84234 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84234/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84233 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84233/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84228/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84228 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84228/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84227/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84227 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84227/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84230 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84230/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84228 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84228/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84227 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84227/testReport)**
for PR 19468 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19468
I went through the changes to make sure the non-k8s changes are ok. They do
look ok to me. From that perspective, LGTM.
---
-
To
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19468
Hi! I think we have quorum at this point.
Not sure if folks are around to review during the holiday, but I plan to do
another final round within a day or so, and merge unless anyone has any
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84116/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84116 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84116/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84114/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84114 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84114/testReport)**
for PR 19468 at commit
Github user erikerlandson commented on the issue:
https://github.com/apache/spark/pull/19468
@reviewers, just as a PSA we have to rebase the second PR (containing the
submission client) _after_ this one merges, and then we can submit the second
one against this upstream. This is a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84116 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84116/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84114 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84114/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84096/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84096 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84096/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84096 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84096/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84088/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84088 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84088/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84088 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84088/testReport)**
for PR 19468 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19468
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/19468
retest this please
Failure looks unrelated.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84084/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84084 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84084/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84084 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84084/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84083 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84083/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84083/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #84083 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84083/testReport)**
for PR 19468 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19468
Sounds good to me, also cc @sameeragarwal @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/19468
@mridulm @vanzin @mateiz @rxin This is waiting for another LGTM I think
(aside from the one by @jiangxb1987). If all parties have no major changes to
suggest, may I propose we merge this before
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/19468
I am actually quite swamped right now, hence the delay in getting to this
PR.
I will try to take a pass over the weekend; but if it does get merged if
@vanzin is ok with it, fine by me !
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19468
I'll let others take a look first (also because I'll be out traveling real
soon...).
---
-
To unsubscribe, e-mail:
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/19468
@vanzin @jiangxb1987 @mridulm We have addressed all the comments so far. Is
this good to merge?
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83903/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83903 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83903/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83903 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83903/testReport)**
for PR 19468 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19468
@mridulm It would be great if you could look at this again, thanks!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83851/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83851 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83851/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83851 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83851/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83830/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83830 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83830/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83830 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83830/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83800/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83800 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83800/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83789/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83789 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83789/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83800/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83789 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83789/testReport)**
for PR 19468 at commit
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/19468
@vanzin @mridulm @jiangxb1987 https://github.com/apache/spark/pull/19717 is
the second part of this PR which has the client-side and spark-submit changes.
The two in combination should make a lot
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19468
ping @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19468
The plan looks good, I'm going to review another round recently, thanks!
---
-
To unsubscribe, e-mail:
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/19468
@mridulm @jiangxb1987 @vanzin thanks for taking the time to review this. Is
there another round of reviews that you guys would want to do here? We're
hoping to get this and just **one other** PR
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83425/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83425 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83425/testReport)**
for PR 19468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83425/testReport)**
for PR 19468 at commit
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/19468
@foxish @mridulm Heads up - since the last review iteration, I wrote an
extra test in `KubernetesClusterSchedulerBackend` that exposed a bug where if
executors never register with the driver but
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83309 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83309/testReport)**
for PR 19468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83100/
Test PASSed.
---
1 - 100 of 151 matches
Mail list logo
