Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19480
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83129/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83129 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83129/testReport)**
for PR 19480 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83127/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83127 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83127/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83129 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83129/testReport)**
for PR 19480 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19480
@gatorsmile sorry, I wasn't aware. Thank you anyway.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19480
LGTM pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19480
@mgaido91 https://github.com/apache/spark/pull/18377 was reverted. I
believe we are unable to merge this to 2.2. Sorry for that.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19480
Thank you all for your reviews. I addressed the last comments.
@gatorsmile meanwhile may I ask you to backport this to branch-2.2 when it
will be merged?
Thanks.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83127 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83127/testReport)**
for PR 19480 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19480
LGTM except two comments.
Thanks for your work!!! @mgaido91
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83119/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83119/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83119/testReport)**
for PR 19480 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83084/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83084 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83084/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83084 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83084/testReport)**
for PR 19480 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83079/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83079 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83079/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83079 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83079/testReport)**
for PR 19480 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83052/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83052 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83052/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83052 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83052/testReport)**
for PR 19480 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83047/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83047/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #83047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83047/testReport)**
for PR 19480 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19480
@kiszk Thanks!
@mgaido91 I have not reviewed it carefully. Will do another pass in the
next few days. Thanks for your fix!
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19480
Sounds good to me. Sorry for being late since I was busy last week.
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19480
@kiszk Does this look good to you?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19480
cc @rednaxelafx Do you have a bandwidth to review this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82861/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82861 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82861/testReport)**
for PR 19480 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82858/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82858 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82858/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82861 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82861/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82858 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82858/testReport)**
for PR 19480 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19480
Could you resolve conflicts, @mgaido91 ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19480
@bdrillard thanks but we removed the "guilty" test case for many reasons.
Thank you anyway.
---
-
To unsubscribe, e-mail:
Github user bdrillard commented on the issue:
https://github.com/apache/spark/pull/19480
@mgaido91 It is possible to increase the heap allocated during testing if
that seems like a desirable thing to do (I did so for #18075, but the current
default is already 4GB), see [1] and [2]
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82758/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82758 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82758/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82758/testReport)**
for PR 19480 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82735/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82735 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82735/testReport)**
for PR 19480 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19480
sorry, the test failure is due to an OutOfMemory exception. I don't know
whether it is possible to change the heap size used by sbt in the Jenkins job
and I am not sure this is the right thing to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82734/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82734 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82734/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82735 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82735/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82734 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82734/testReport)**
for PR 19480 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19480
The current change LGTM.
If you can have an end-to-end test for this. This might be better. This
seems not an issue very easy to encounter by end users. Can you try to have
one? @mgaido91
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82697/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82697/testReport)**
for PR 19480 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82697/testReport)**
for PR 19480 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82687/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19480
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19480
**[Test build #82687 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82687/testReport)**
for PR 19480 at commit
70 matches
Mail list logo
