Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19492
Closing as we have a newer PR (https://github.com/apache/spark/pull/21439)
which uses the refactored classes (which made the change easier compared to
this PR). Thanks.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19492
I am actually still hesitant. FWIW, there's another PR for this if I am not
mistaken - `https://github.com/apache/spark/pull/21439`. I don't quite like
that approach too but at least that has
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19492
@HyukjinKwon as there were questions about whether this PR is useful or
not, what do you think? Shall we go on on this or shall I close it? Thanks.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19492
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19492
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/377/
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19492
@viirya The point is that most of the times the input format is not decided
by the Spark users and I have seen some "provider of input sources" generating
data in this format. It might not be the
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19492
In fact I don't feel strong preference to support array of primitive types
in `from_json`.
The reason is that I think at most time, we will use json object instead of
json array at
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19492
Kindly ping @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19492
@viirya did you have any chance to look at this? Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19492
@HyukjinKwon I am not sure that the amount of change is more important than
fixing a misbehavior, since now we are rejecting to parse valid JSONs.
Moreover, I think that most of the complexity
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19492
I will be busy on relocating in next few days. I'll look into this further
if I have time in maybe weekend.
---
-
To
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19492
To be honest, just to share what have been on my mind on this so far, I
have been trying to think if it's worth vs the amount of changes, in
particular, we now happen to have some divergence,
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19492
any more comments on this @viirya @HyukjinKwon?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19492
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19492
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85516/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19492
**[Test build #85516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85516/testReport)**
for PR 19492 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19492
**[Test build #85516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85516/testReport)**
for PR 19492 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19492
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85509/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19492
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19492
**[Test build #85509 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85509/testReport)**
for PR 19492 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19492
**[Test build #85509 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85509/testReport)**
for PR 19492 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19492
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85507/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19492
**[Test build #85507 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85507/testReport)**
for PR 19492 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19492
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19492
**[Test build #85507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85507/testReport)**
for PR 19492 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19492
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19492
kindly ping @viirya @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19492
@viirya sorry, do you have any more comments?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19492
@HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19492
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
30 matches
Mail list logo
