Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19514
Oops yes meant 2.0
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19514
@srowen, not a big deal but .. I believe it's merged to 2.0 instead of
master though.
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19514
Merged to master @FRosner ; you'll have to close this manually too
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19514
Thanks, I have been following it @shivaram and @felixcheung. Separate JIRA
sounds good to me and I am okay witn merging it.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19514
LGTM too BTW.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19514
I think we can safely merge this change as it clearly passes any tests
whose functionality it would affect. We could defer further discussion about
what to do about CRAN versions elsewhere, yes.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/19514
Good point. I'm not sure it counteracts it completely. We should run it to
see the behavior I guess.
I am not a big fan of mucking with Jenkins versions because it
fundamentally looks
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19514
I haven't tried it, but it might sound like it will counter-act -as-cran
check sets completely?
```
R_CHECK_CRAN_INCOMING_
Check whether package is suitable for publication on CRAN.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19514
whoa.
`_R_CHECK_CRAN_INCOMING_= false` sounds like the right approach. I'm a bit
concerned with blindly letting through one more warning though, perhaps grep
for the specific warning text
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/19514
We didn't foresee this but it looks like `R CMD check --as-cran` throws
this error if we try to build a package with a version number older than the
one uploaded to CRAN.
There are a
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19514
@shivaram do you know if this error means branch 2.0 won't pass R CRAN
checks at this point?
```
Running CRAN check with --as-cran --no-tests --no-manual options
* using log
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19514
**[Test build #3956 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3956/consoleFull)**
for PR 19514 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19514
**[Test build #3956 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3956/consoleFull)**
for PR 19514 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19514
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82901/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19514
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19514
**[Test build #82901 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82901/consoleFull)**
for PR 19514 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19514
**[Test build #82901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82901/consoleFull)**
for PR 19514 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19514
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19514
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82883/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19514
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19514
**[Test build #82883 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82883/consoleFull)**
for PR 19514 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19514
**[Test build #82883 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82883/consoleFull)**
for PR 19514 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19514
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19514
**[Test build #3949 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3949/consoleFull)**
for PR 19514 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19514
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
25 matches
Mail list logo
