Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19521
Thank you all for review and merge!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19521
Thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19521
Thank you, @rxin !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/19521
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19521
cc @srowen @rxin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19521
Thank you for review, @HyukjinKwon .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19521
Empty schema path probably related with this IIRC (not double checked):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19521
LGTM too BTW.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19521
Oh, I confused with what I'm watching in these days.
For your example, Parquet also doesn't support. We may create an issue for
both Parquet/ORC on empty schema .
```scala
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19521
`SPARK-15474 ` is zero row. The above case is zero column. Are they the
same issues?
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19521
Thank you for review, @gatorsmile .
1. The test case was added at #15898 (SPARK-18457). I guess Parquet returns
`null`, but we had better have explicit test cases. I will try to
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19521
We can save an empty DataFrame as an ORC table, but we are unable to fetch
it from the table.
```Scala
val rddNoCols = sparkContext.parallelize(1 to 10).map(_ => Row.empty)
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19521
Also LGTM
Regarding the test case you posted, does Parquet return `null` or `empty
string`?
---
-
To unsubscribe,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19521
Thank you for review, @cloud-fan !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19521
looks good, no new dependencies introduced, just upgrading. cc @srowen to
double check. Thanks!
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19521
Hi, @gatorsmile and @cloud-fan .
This will remove the regression on on-going ORC PRs.
- [test("Empty schema does not read data from ORC
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19521
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82853/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19521
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19521
**[Test build #82853 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82853/testReport)**
for PR 19521 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19521
**[Test build #82853 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82853/testReport)**
for PR 19521 at commit
20 matches
Mail list logo
