[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2018-03-20 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/19599 Please advice if this is a good feature to add. If not I'll close it. Thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84887/ Test PASSed. ---

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #84887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84887/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-13 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/19599 Updated, use $lc and add a new unit test for doc and exception. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #84887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84887/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-13 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/19599 > One option that came to my mind was that $ returns lowercase, so this is used at most places but when you really need it you can access the original (not necessarily lowercase) value. As

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-12 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/19599 Many thanks for the review @smurakozi and @attilapiros. > The PR is not complete (did not convert all Param[String] instances to StringParam consistently) so it should be marked as WIP.

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-12 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/19599 As I see inside the StringParam the options even can be mapped to enum values. This way ignoring cases at the matching part would be no problem at all (and it would be very efficient). Going

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #84699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84699/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84699/ Test FAILed. ---

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #84699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84699/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84698/ Test FAILed. ---

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #84698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84698/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-12-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #84698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84698/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-11-01 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/19599 I used two ways to switch String params among different options: 1. In NaiveBayes: convert StringParam and String constants to lowercase. 2. in LinearRegression: .equalsIgnoreCase

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83199/ Test PASSed. ---

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #83199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83199/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #83199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83199/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83174/ Test FAILed. ---

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19599 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #83174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83174/testReport)** for PR 19599 at commit

[GitHub] spark issue #19599: [SPARK-22381] [ML] Add StringParam that supports valid o...

2017-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19599 **[Test build #83174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83174/testReport)** for PR 19599 at commit