Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19630
Thanks @HyukjinKwon!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19630
Actually, R has a flag for `useDaemon`:
https://github.com/apache/spark/blob/478fbc866fbfdb4439788583281863ecea14e8af/core/src/main/scala/org/apache/spark/api/r/RRunner.scala#L362
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19630
OK, mine was, with this diff:
```diff
---
a/core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala
+++
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19630
thanks, merging to master, cheers!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19630
Everyone, I don't have more changes to the PR. I think all comments are
addressed at this point. Please let me know if I missed anything or there are
more comments. Thank you!
---
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19630
@HyukjinKwon Thanks for the reply on coverage. It'd be great to have an
easy way to run coverage :)
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83962/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83962 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83962/testReport)**
for PR 19630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83965/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83965 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83965/testReport)**
for PR 19630 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83965 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83965/testReport)**
for PR 19630 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19630
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83959/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83959 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83959/testReport)**
for PR 19630 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83962 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83962/testReport)**
for PR 19630 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19630
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83961/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83959 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83959/testReport)**
for PR 19630 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19630
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83956/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83956 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83956/testReport)**
for PR 19630 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19630
which, for example, shows the coverage like this:
The
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19630
To be honest, I know a super hacky funny workaround I use sometimes but ..
want to know if there is any easy way or cleaner way ..
---
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19630
As a side question, is there an easy way to run coverage reports with
pyspark tests?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83956 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83956/testReport)**
for PR 19630 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19630
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83942/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83942 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83942/testReport)**
for PR 19630 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19630
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83942 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83942/testReport)**
for PR 19630 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19630
Looks clean and pretty solid in general. Let me take another look to double
check, probably, within this weekend and maybe I will leave it to @ueshin if I
can take the look ahead.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83906/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19630
**[Test build #83906 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83906/testReport)**
for PR 19630 at commit
40 matches
Mail list logo
