Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Thank you so much for making ORC move forward, @cloud-fan !
Also, thank you, @HyukjinKwon , @gatorsmile , @viirya , @kiszk .
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19651
thanks, merging to master!
followups:
1. add a config to use new orc by default
2. move orc test to sql core
3. columnar orc reader
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
@cloud-fan . It pass the Jenkins again. Could you take a look again?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84396/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84396 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84396/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Now, this PR has only new OrcFileFormat-related addition: 1009
insertions(+), 2 deletions(-)
```
$ git diff master --stat
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84396 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84396/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Sure, @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19651
great, all tests pass! Let's restore to old ORC implementation and merge it.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84393/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84393/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84393/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84378/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84378 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84378/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Thank you so much, @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84378 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84378/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84278/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84278/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84279/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84277/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84277/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84279 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84279/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84279 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84279/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84278/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84277/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84097/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84097 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84097/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #84097 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84097/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Thank you, @cloud-fan . I'll update the PR tomorrow.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19651
ping @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83760/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83760/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83759/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83759/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83760/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83759/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Thank you for review, @viirya .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Thank you so much, @cloud-fan and @gatorsmile . This PR becomes much better.
Now, it's updated and ready for review again.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83737/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83737 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83737/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83737/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83710/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83710 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83710/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83710/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83697/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83697/testReport)**
for PR 19651 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83696/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83696/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83697/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83696/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Thank you for review, @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83677/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83677 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83677/testReport)**
for PR 19651 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19651
I'd like to still keep the old orc implementation in this PR. The new
implementation should only be used when users specify full class name, e.g.
`org.apache.sparkOrcFileFormat`. Then we add
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83677 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83677/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83669/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83669 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83669/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83669 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83669/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Hi, @cloud-fan and @gatorsmile .
Could you review this PR?
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
The PR is updated according to your advice. Thank you again, @cloud-fan !
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83543/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83543 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83543/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83543 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83543/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Right. @HyukjinKwon . I'll follow the final decision on this PR.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19651
@dongjoon-hyun, btw, if I understood correctly,
> Note that this PR intentionally removes old ORCFileFormat to demonstrate
a complete replacement. We will bring back the old
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Thank you so much for review, @cloud-fan . I'll try to update the PR
tonight.
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Hi, @cloud-fan and @gatorsmile .
According to the decision at #19571 , I made a ORCFileFormat under
`sql/core` again.
Could you review this PR?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83433/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83433 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83433/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83433 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83433/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83431/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83431/testReport)**
for PR 19651 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19651
**[Test build #83431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83431/testReport)**
for PR 19651 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83427/
Test FAILed.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19651
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19651
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83423/
Test FAILed.
---
1 - 100 of 117 matches
Mail list logo
