[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2018-06-17 Thread yoelb
Github user yoelb commented on the issue: https://github.com/apache/spark/pull/19687 I have the same issue @ManchesterUnited16 , did you find a solution? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-10 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19687 @ManchesterUnited16 Since I tested your codes and it works for me, I'm going to merge this PR and backport it to 2.2. If it's a real issue, feel free to open a ticket with steps to reproduce it.

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-09 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19687 > can you show me you maven dependency when you ran the program,thank you very much! maven dependency is used only when I compiled the codes. I used the official Spark 2.2.0 to compile the

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-09 Thread ManchesterUnited16
Github user ManchesterUnited16 commented on the issue: https://github.com/apache/spark/pull/19687 can you show me you maven dependency when you ran the program,thank you very much! At 2017-11-09 13:37:46, "Shixiong Zhu"

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19687 @ManchesterUnited16 I ran your codes and didn't see `NotSerializableException`. How did you patch Spark with my PR? --- - To

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread ManchesterUnited16
Github user ManchesterUnited16 commented on the issue: https://github.com/apache/spark/pull/19687 import org.apache.spark.ml.evaluation.RegressionEvaluator import org.apache.spark.ml.recommendation.{ALS, ALSModel} import org.apache.spark.ml.recommendation.ALS.Rating import

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19687 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83608/ Test PASSed. ---

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19687 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19687 **[Test build #83608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83608/testReport)** for PR 19687 at commit

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19687 > LGTM, is it targeted for branch 2.2 too? Yeah, I will backport this to 2.2 once this PR gets merged. --- - To

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19687 @ManchesterUnited16 `cleanUpReflectionObjects` introduces new closures but those are created in `object ScalaReflection` so should be safe. Did you backport my PR to an old Spark version? If

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19687 **[Test build #83608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83608/testReport)** for PR 19687 at commit

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19687 > java.io.NotSerializableException: scala.reflect.api.TypeTags$PredefTypeCreator @ManchesterUnited16 Probably this change may capture some unnecessary objects. Could you provide your codes

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19687 LGTM, is it targeted for branch 2.2 too? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread ManchesterUnited16
Github user ManchesterUnited16 commented on the issue: https://github.com/apache/spark/pull/19687 java.io.NotSerializableException: scala.reflect.api.TypeTags$PredefTypeCreator --- - To unsubscribe, e-mail:

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-08 Thread ManchesterUnited16
Github user ManchesterUnited16 commented on the issue: https://github.com/apache/spark/pull/19687 there is something wrong in my program --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19687 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83571/ Test PASSed. ---

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19687 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19687 **[Test build #83571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83571/testReport)** for PR 19687 at commit

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19687 **[Test build #83571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83571/testReport)** for PR 19687 at commit

[GitHub] spark issue #19687: [SPARK-19644][SQL]Clean up Scala reflection garbage afte...

2017-11-07 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19687 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: