Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu @maropu sure, thanks, I'll submit a PR for this soon. Thanks.
---
-
To unsubscribe, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
ok @mgaido91 can u take this over?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
@maropu
Sorry. I don't really have much time this month.
I can close this pr and somebody can continue on this problem.
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu still busy?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
Sorry guys. little busy recently.
I will resolve the failed tests this weekend first.
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
if @DazhuangSu is not active anymore on this I can take it over, but let's
wait for his answer.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95451/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #95451 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95451/testReport)**
for PR 19691 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu Are u there?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #95451 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95451/testReport)**
for PR 19691 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19691
Could anyone take over this then?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19691
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu are you still working on this? There is this
[comment](https://github.com/apache/spark/pull/19691#discussion_r205013855) and
also another nit which need to be addressed from the last
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
@HyukjinKwon can you trigger again?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
@maropu ok
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu Can you resolve the conflict?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MKervo commented on the issue:
https://github.com/apache/spark/pull/19691
Could someone merge this please ? :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93052/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #93052 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93052/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #93052 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93052/testReport)**
for PR 19691 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19691
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91473/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91473 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91473/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91473 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91473/testReport)**
for PR 19691 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91393/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91393/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91393/testReport)**
for PR 19691 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91352/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91352 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91352/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91352 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91352/testReport)**
for PR 19691 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91308/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91308 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91308/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91308 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91308/testReport)**
for PR 19691 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91152/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91152 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91152/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91152 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91152/testReport)**
for PR 19691 at commit
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
@mgaido91 It's totally ok to do it in parser.
I was thinking it's may need to change more codes in SqlBase than now and
it's only for this case.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu why can't we enforce it in the parser?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
@mgaido91 Will it be ok to support Literal only on the right-side like this?
https://github.com/apache/spark/pull/19691/files#diff-9847f5cef7cf7fbc5830fbc6b779ee10R295
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu may you also please address
https://github.com/apache/spark/pull/19691/files#r179944192? Thanks.
---
-
To
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu if this is hive behavior, I agree with you about using
intersect.
---
-
To unsubscribe, e-mail:
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
@mgaido91
What's you opinion about this review by now?
https://github.com/apache/spark/pull/19691/files#r179940757
I think it's more reasonable to use `intersect`.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90948/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #90948 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90948/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #90948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90948/testReport)**
for PR 19691 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
You don't address all the comments? e.g., how about the @mgaido91 comment?
https://github.com/apache/spark/pull/19691/files#r179944192
Also, you need to add tests for a non-supported left-side
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
@maropu @mgaido91
path has passed all tests. Any advice please?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90911/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #90911 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90911/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #90911 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90911/testReport)**
for PR 19691 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
the failed UTs are valid failures
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90894/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #90894 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90894/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #90894 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90894/testReport)**
for PR 19691 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
thanks @DazhuangSu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
@mgaido91 Sorry, a little busy recently.
pr is almost ready. Will update soon.
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu are you still working on this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89029/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #89029 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89029/testReport)**
for PR 19691 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu I think you'd better to file a new jira for this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #89029 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89029/testReport)**
for PR 19691 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
ok
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89023/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #89023 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89023/testReport)**
for PR 19691 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19691
@dongjoon-hyun @maropu @mgaido91 Could you review this PR? I think this
command is a pretty useful to end users.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #89023 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89023/testReport)**
for PR 19691 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19691
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
@gatorsmile @dongjoon-hyun
Could you give me some advice please?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83839/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #83839 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83839/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #83839 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83839/testReport)**
for PR 19691 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83838/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #83838 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83838/testReport)**
for PR 19691 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #83838 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83838/testReport)**
for PR 19691 at commit
Github user DazhuangSu commented on the issue:
https://github.com/apache/spark/pull/19691
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83832/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #83832 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83832/testReport)**
for PR 19691 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #83832 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83832/testReport)**
for PR 19691 at commit
1 - 100 of 112 matches
Mail list logo
