[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-28 Thread skambha
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 great! Thank you @gatorsmile, @hvanhovell, @wzhfy --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-28 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/19747 LGTM - merging to master. Thanks for working on this! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84271/ Test PASSed. ---

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #84271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84271/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19747 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-28 Thread skambha
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 Thanks @gatorsmile. I have addressed your comments in the latest commit. Please take a look. Thanks. --- - To

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #84271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84271/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19747 LGTM except a few minor comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84238/ Test PASSed. ---

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #84238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84238/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-27 Thread skambha
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 Thanks @gatorsmile for your comments. I have incorporated them in the latest commit: https://github.com/apache/spark/pull/19747/commits/a1c8a6d308b62f3439f07dbf3257b51855cb09d8 Please

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #84238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84238/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83969/ Test PASSed. ---

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83969/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83968/ Test PASSed. ---

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83968/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83969/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-17 Thread skambha
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 I have taken care of adding the check in the new HiveClientImpl.alterTableDataSchema as well and have added some new tests. ---

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83968/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83888/ Test PASSed. ---

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83888 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83888/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-15 Thread skambha
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 I synced up and noticed there are some recent changes that have gone in that changes the alter table schema codepath in the HiveExternalCatalog. I'll take a look and see what changes might be

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-15 Thread skambha
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19747 Thanks @wzhfy for your comments. I have addressed them in the latest commit. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83888/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83879/ Test PASSed. ---

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83879/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19747 **[Test build #83879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83879/testReport)** for PR 19747 at commit

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-14 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19747 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-14 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/19747 Ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19747: [Spark-22431][SQL] Ensure that the datatype in the schem...

2017-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19747 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional