Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19755
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19755
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19755
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19755
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19755
can you give a simple example to convince people that un-reused subqueries
should be displayed separately? the TPC-DS example is really hard to read.
---
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19755
I can't find a way to distinguish `reused` and `unreused` subquery. For
example, in the `ReuseSubquery` rule, after seeing the 1st SubqueryExec(with
`unreused` in name), it's buffered. When the
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19755
Also update the UI images in the PR description?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19755
How do you define "correctly"? Logically I think it makes sense to not
duplicate subquery in the query plan, but your concern about how to distinguish
`reused` and `not reused` subquery is also
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19755
This targets on subquery that's not reused, the reused subquery is
correctly shown in UI now. @cloud-fan
---
-
To unsubscribe,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19755
instead of duplicating the sub query tree, how about we just add something
in the plan name? e.g. `Subquery (reused)`.
---
-
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19755
can we use a simple example to demonstrate it? I can hardly read the image
in PR description...
---
-
To unsubscribe, e-mail:
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19755
But it might make users confused, I think what shows on UI is supposed to
be exactly things that get executed. Maybe accuracy is more important than
clearness for this.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19755
IMHO, the duplicated subquery nodes make the UI too complicated to read.
Considering UI clearness, I suspect that it is necessary to have duplicated
subquery nodes.
---
Github user carsonwang commented on the issue:
https://github.com/apache/spark/pull/19755
Can you please show the UI before and after the change?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19755
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19755
@cloud-fan @viirya @carsonwang @gatorsmile @yucai Could you please help me
review this?
---
-
To unsubscribe, e-mail:
16 matches
Mail list logo
