Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
Thanks @hvanhovell .IIUC, you mean that adding second order will break the
contract of the range partitioner generated by `ShuffleExchange` ?If that, i
agree with the opinionã
And sorry for
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19764
@caneGuy adding the second ordering makes the sort much more fine grained,
this means that the range partitioner is probably going to use different range
boundaries using all the ordering
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19764
I'm probably not qualified to review this. I don't think you addressed
Herman's question. It wasn't about ordering or whether the same exact row maps
to the same partition, but whether all values
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
Ping @srowen can you help review this?Thanks too much
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19764
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
Ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
@gczsjdy Added a simple example.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
@gczsjdy Ok,i will post later.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19764
@caneGuy Can you give a specific example to illustrate your change? Maybe
former partition result & later partition result?
---
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
Ping any admin help review this?Thanks
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/19764
Firstly , thanks too much @hvanhovell .
And sorry for replying so late since i have some other things to handle
during these time.
For the question, i think the ordering will not be broken.I
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19764
Doesn't this break the `Partitioner` contract? Rows for the same key will
now map to multiple partitions.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19764
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
13 matches
Mail list logo
