Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19845
Merged to master.
Thanks for reviewing this @viirya, @jiangxb1987, @dongjoon-hyun and
@imatiach-msft.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19845
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84369/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19845
**[Test build #84369 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84369/testReport)**
for PR 19845 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19845
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19845
**[Test build #84369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84369/testReport)**
for PR 19845 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19845
@HyukjinKwon Thanks. I forgot the Hive support is needed to test it. The
added test looks good.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19845
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19845
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84342/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19845
**[Test build #84342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84342/testReport)**
for PR 19845 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19845
**[Test build #84342 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84342/testReport)**
for PR 19845 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19845
@viirya, actually, I think it's not that simple to just add multiple
`ImageSchema.readImages` (if you thought this way). I think I need another
class with a Hive support enabled session. Let me
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19845
@imatiach-msft, ah, I think it's not about SparkContext but SparkSession,
(SparkSession(...) directly) to be more clear, which seems causing multiple
Hive clients when Hive support is enabled.
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/19845
LGTM as long as all tests pass - but what about the other methods that use
"ctx = SparkContext._active_spark_context" -- should those be modified as well?
Can you run those one after the
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19845
Shall we also add a simple test to `ImageReaderTest`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19845
Thanks for reviewing this @jiangxb1987, @dongjoon-hyun and @viirya.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19845
Let me look into this tomorrow. :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19845
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84297/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19845
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19845
**[Test build #84297 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84297/testReport)**
for PR 19845 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19845
cc @jiangxb1987, @viirya who I am seeing touched and reviewed similar
codes, and @imatiach-msft who's the primary author of this codes.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19845
**[Test build #84297 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84297/testReport)**
for PR 19845 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19845
I could fold this change into `https://github.com/apache/spark/pull/19835`.
I only opened a separate PR here as it was easy to describe this issue
separately and seems another issue although
22 matches
Mail list logo
