Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19856
This is trivial and not obviously a useful change, so it should be closed
---
-
To unsubscribe, e-mail:
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/19856
@jerryshao
Yes,you are right,but this log is not accurate,I think it should log like
this "consumerconnector has been created",it is too ambiguity now.
---
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19856
>I think the log can't reflect the behavior of consumer connection,because
consumer.create doesn't do any connect,it only construct a
ZookeeperConsumerConnector instance
That's not true,
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19856
Actually there's no issue here, IMHO I think your understanding of this log
is slightly different from the original purpose.
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/19856
@jerryshao
I think the log can't reflect the behavior of consumer connection,because
consumer.create doesn't do any connect,it only construct a
ZookeeperConsumerConnector instance,so the
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19856
I guess the original purpose of such log is to reflect the behavior of
consumer connection. It is not super necessary to do such trivial change. Also
`ReliableKafkaReceiver` is not recommended
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/19856
@srowen
Please help merge this PR as it has passed all tests.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19856
**[Test build #4002 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4002/testReport)**
for PR 19856 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19856
**[Test build #4002 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4002/testReport)**
for PR 19856 at commit
Github user liu-zhaokun commented on the issue:
https://github.com/apache/spark/pull/19856
@srowen
Thanks for your reply.Could you help me review it?
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19856
You shouldn't create a JIRA for items like this, where the description is
the same as the PR. I wouldn't move the initial log, as creating the Consumer
is part of connecting. It won't matter much.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19856
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
12 matches
Mail list logo
