Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
Thanks all for review!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19872
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86492/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86492/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86492/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/109/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86487/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86487 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86487/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86487 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86487/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/106/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
Addressed latest comments. Yeah I think master only is fine.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19872
+1 for master-only. We can cherry-pick and backport if we should even after
this gets merged anyway. For a reminder, we should complete the doc
https://github.com/apache/spark/pull/19575 too.
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
@ueshin I think all comments are addressed. Can you take a final look?
Thanks!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86350/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86350 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86350/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86346/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86346 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86346/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86350/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/5/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86346 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86346/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86344/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86344 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86344/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86345/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86345 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86345/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86345/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86344/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86280/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86280 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86280/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86279/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86279 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86279/testReport)**
for PR 19872 at commit
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
@HyukjinKwon I addressed your comments (thanks for the thorough check
BTW!).
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86280/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86279 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86279/testReport)**
for PR 19872 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19872
Only few nits. LGTM but let me leave it to @ueshin.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
Hi all. I have addressed all comments. Let me know if you have any more
comments. Thank you!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86196/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86196 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86196/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86188/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86188 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86188/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86189/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86189 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86189/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86187/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86187 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86187/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86196 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86196/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86189/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86188/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #86187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86187/testReport)**
for PR 19872 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19872
I don't have any concerns for merging it as is for now. Will double check
tonight for sure. Was wondering if it generally looks good to you.
---
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19872
LGTM.
@HyukjinKwon Do you have any concerns about this?
I'd also cc @cloud-fan for another look.
---
-
To unsubscribe,
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
@ueshin I think this PR is close to be merged. About you comment
https://github.com/apache/spark/pull/19872#pullrequestreview-87762872 on udaf
that supports partial aggregation, is there
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85947/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85947/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85947/testReport)**
for PR 19872 at commit
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85932/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85932 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85932/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85932 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85932/testReport)**
for PR 19872 at commit
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85928/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85928 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85928/testReport)**
for PR 19872 at commit
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
@ueshin and @HyukjinKwon Thanks much for the review. I have addressed the
latest comment.
@ueshin I think UDAF that supports partial aggregation can be build on top
of this. The
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85928/testReport)**
for PR 19872 at commit
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/19872
Ping @ueshin, do you think of the current state of the PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19872
Hey @ueshin, Will check and help double check anyway but is it closer to
what you think BTW? I saw you made many prototypes and wonder if this one
sounds generally okay to you.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85613/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85613 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85613/testReport)**
for PR 19872 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85613 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85613/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85605/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85605 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85605/testReport)**
for PR 19872 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85604/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19872
**[Test build #85604 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85604/testReport)**
for PR 19872 at commit
92 matches
Mail list logo
