Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
Thank you so much, @cloud-fan , @HyukjinKwon , and @gatorsmile !
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19882
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84599/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84599 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84599/testReport)**
for PR 19882 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84599 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84599/testReport)**
for PR 19882 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19882
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84591/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84591 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84591/testReport)**
for PR 19882 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84589/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84589 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84589/testReport)**
for PR 19882 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84591/testReport)**
for PR 19882 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
Definitely, my bad.
For the main code, we can do later in a separate PR if needed. I hope this
PR contains tests only.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19882
I am sorry, I had to clarify this ahead ..
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
Oh. I'll bring back.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19882
I meant in
https://github.com/apache/spark/pull/19882#pullrequestreview-81708676, I liked
this `Hive` prefix here so wondered if we could do the same thing for the main
codes too. Since this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19882
I actually suggested similarly before:
```
org.apache.spark.sql.execution.datasources.csv.InferSchema
org.apache.spark.sql.execution.datasources.json.InferSchema
```
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19882
Yup but I actually received an advise before. I suggested:
```
```
```
org.apache.spark.sql.execution.datasources.csv.CSVInferSchema
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
@HyukjinKwon . The PR code and description is updated.
- Update comments
- Rename back to the originals
The main reason I used prefix `Hive` is for naming consistency, but now
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84589/testReport)**
for PR 19882 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
Thank you so much, @HyukjinKwon !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84581/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84581 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84581/testReport)**
for PR 19882 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19882
LGTM BTW.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84581 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84581/testReport)**
for PR 19882 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
It's rebased to the master to resolve conflicts. Also, I addressed the
comments. Thanks!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84524/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84524 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84524/testReport)**
for PR 19882 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84524 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84524/testReport)**
for PR 19882 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
Okay. No problem. Thanks, @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19882
ok maybe have a `def orcImp: String`, which can be `native` or `hive`. Then
we can put the `beforeAll` and `afterAll` in `OrcTest`.
It can avoid changing the test code from
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
It has more lines, doesn't it? In any way, we need helper functions.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19882
> OrcTest will provide common helper functions and def format: String.
Instead of having `def format: String`, can we just add `beforeAll` and
`afterAll` in the test suites to set the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
Thank you so much, @HyukjinKwon !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19882
Whoa big class list. Will take a look soon within tomorrow as well.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84443/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19882
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84443 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84443/testReport)**
for PR 19882 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19882
Hi, @cloud-fan , @gatorsmile , @HyukjinKwon , @viirya .
This is a test case restructure after
https://github.com/apache/spark/pull/19651 .
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19882
**[Test build #84443 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84443/testReport)**
for PR 19882 at commit
44 matches
Mail list logo
