Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85263/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85263 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85263/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85263 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85263/testReport)**
for PR 19981 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85251/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85251 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85251/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85251 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85251/testReport)**
for PR 19981 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19981
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85238/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85238 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85238/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85238 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85238/testReport)**
for PR 19981 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85227/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85227 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85227/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85227 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85227/testReport)**
for PR 19981 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
cc @vanzin any more comments?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85093/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85093 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85093/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85091/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85091 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85091/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85093 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85093/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85091 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85091/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85065/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85065/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85064/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85064 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85064/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85065/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85064 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85064/testReport)**
for PR 19981 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19981
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85047/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85047/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85047/testReport)**
for PR 19981 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85042/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85042 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85042/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85042 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85042/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85041/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85041/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85041/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85040/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85040 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85040/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #85040 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85040/testReport)**
for PR 19981 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
@vanzin We can add `AppStatusPlugin` back if you can convince other people
that the SQL listener and UI tag should be set up during `SparkContext`
initialization(I'm kind of convinced after some
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84994 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84994/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84994/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84994 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84994/testReport)**
for PR 19981 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19981
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84967 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84967/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84967/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84967 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84967/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84947/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84947/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84947/testReport)**
for PR 19981 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84943/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84943/testReport)**
for PR 19981 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84943 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84943/testReport)**
for PR 19981 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19981
It's less about cleanliness and more about discoverability IMO. Answer the
question quickly: where is the SQL UI initialized?
- my code: in the AppStatePlugin implementation
- your code:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
Internal behavior change also needs careful review, I'd like to wait for
feedback from others.
But is the previous code really that hacky and worth a factor with a new
interface?
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19981
> It's possible that people writing Spark applications with Spark SQL
dependency, but not using SQL
Yes, and the SQL listener will ignore all the events, as it should even in
the case that
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
> Not sure why that would be an issue - or rather, why that's different
from the what's always been the case.
It's possible that people writing Spark applications with Spark SQL
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19981
> We are going to, right? Otherwise creating the interface just for SQL
doesn't align with your goal to centralize this part.
At some point, probably, but supporting streaming UIs in the SHS
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
> Those are not being installed with this interface, are they?
We are going to, right? Otherwise creating the interface just for SQL
doesn't align with your goal to centralize this part.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19981
> Code readability is important to Spark, we should not sacrifice it
without real benefits.
I agree, but I also think that duplicating code in disjoint places hurts
readability, not helps
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
So the problem is, it takes me a while to understand the new code, because
of the weird design for `AppStatusPlugin`. At least we should have a separate
plugin interface for live UI. Code
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19981
> I also not sure why we need a plugin interface for live UI.
So your solution to that is to have completely separate code for both
cases? I really prefer to have a single place to go to to
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
I don't think `AppStatusPlugin` is well designed to support both live and
history server. The fact that `SQLAppStatusPlugin` needs flags to decide to
register the listener in `setupListeners` or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84922 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84922/testReport)**
for PR 19981 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84922/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19981
**[Test build #84922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84922/testReport)**
for PR 19981 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19981
I intentionally created that interface to be used both by live applications
and the SHS. What actual problem are you running into?
> we should not register SQLListener if users are not using
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19981
cc @vanzin @gengliangwang @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
91 matches
Mail list logo
