[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19982 ok, I just look forward to the proposal. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19982 @maropu Thanks for your contribution. It looks over engineering. We do not need such complicated solutions for this simple use case. We just need to record them in the log. We are also proposing

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-22 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19982 @gatorsmile Any progress on this? https://github.com/apache/spark/pull/19982#discussion_r157119941 After I thought your comment, I came up with collecting metrics for each rule like;

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19982 https://github.com/apache/spark/pull/19990 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19982 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19982 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84940/ Test PASSed. ---

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19982 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19982 **[Test build #84940 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84940/testReport)** for PR 19982 at commit

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19982 yea, sure. I have much bandwidth now :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19982 cc @maropu Feel free to submit a PR for adding SSB --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19982 **[Test build #84940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84940/testReport)** for PR 19982 at commit

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19982 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19982 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84936/ Test PASSed. ---

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19982 **[Test build #84936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84936/testReport)** for PR 19982 at commit

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19982 LGTM with one minor comment. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19982 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19982 **[Test build #84936 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84936/testReport)** for PR 19982 at commit

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19982 Probably, we could get sql queries from here https://github.com/electrum/ssb-dbgen (I don't look into yet though...) --- - To

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19982 yea. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19982 https://www.cs.umb.edu/~poneil/StarSchemaB.PDF This one? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19982 LGTM for one minor comment. BTW, how about also adding star schema benchmark (many join cases) to check compilation? --- -

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19982 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84928/ Test PASSed. ---

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19982 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19982 **[Test build #84928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84928/testReport)** for PR 19982 at commit

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19982 **[Test build #84928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84928/testReport)** for PR 19982 at commit

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19982 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19982 **[Test build #84927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84927/testReport)** for PR 19982 at commit

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19982 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84927/ Test FAILed. ---

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19982 **[Test build #84927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84927/testReport)** for PR 19982 at commit

[GitHub] spark issue #19982: [SPARK-22787] [TEST] [SQL] Add a TPC-H query suite

2017-12-14 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19982 cc @cloud-fan @maropu @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,