[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-23 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20018 Thanks @HyukjinKwon @wangyum --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20018 Thank you @wangyum :D. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-23 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/20018 Thanks @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20018 I just opened a quick hotfix - https://github.com/apache/spark/pull/20065 as I think we don't run examples in the build and tests and all we need would just be the style. Reverting

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20018 Seems this did not passed the test .. this causes a build failure: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85343/console ```

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20018 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20018 @srowen Apologize, i was not aware with that PMC member gets auto notification for the same. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-22 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20018 @chetkhatri no need to keep pinging. We intentionally leave these changes open for review for a day or more to make sure everyone has seen it who wants to. ---

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-22 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20018 @HyukjinKwon @srowen Kindly review now, if looks good do merge. Thanks --- - To unsubscribe, e-mail:

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-20 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20018 Adding other contributor of the same file for review. cc\ @cloud-fan @aokolnychyi @liancheng @HyukjinKwon ---

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-20 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20018 @srowen Can you please review and if everything seems correct then run test build --- - To unsubscribe, e-mail:

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20018 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20018: SPARK-22833 [Improvement] in SparkHive Scala Examples

2017-12-19 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20018 @holdenk @sameeragarwal Please do review and do needful . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org