Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20025
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20025
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
@gatorsmile @liufengdb Anything else? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86508/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86508 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86508/testReport)**
for PR 20025 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86508 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86508/testReport)**
for PR 20025 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86370/testReport)**
for PR 20025 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86370/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86370/testReport)**
for PR 20025 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86349/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86349 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86349/testReport)**
for PR 20025 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86349 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86349/testReport)**
for PR 20025 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20025
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20025
@gatorsmile @felixcheung I left one comment, otherwise lgtm.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
@cloud-fan @gatorsmile @liufengdb @felixcheung @srowen @vanzin Is anybody
could make further contact and discuss this PR? Thanks!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86231/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86231 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86231/testReport)**
for PR 20025 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86231 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86231/testReport)**
for PR 20025 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86167/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86167/testReport)**
for PR 20025 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #86167 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86167/testReport)**
for PR 20025 at commit
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
ping @liufengdb
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
ping gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
@gatorsmile What is your opinion about this? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20025
My understanding is that the reflection was used because we might use a
different version of hive then we didn't control what it was done inside the
`super.init`. However, after we inlined the
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
@rxin Could you please to review this? Thanks.
In my opinion we can create a new or follow-up PR if refactor is necessary.
This PR is to fix the bug about the Session Timeout Checker
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
@liufengdb I think the class `SessionManager.java` is merged from Hive
originally, and in Spark we redesigned it by adding
`SparkSQLSessionManager.scala` with no affect to `SessionManager.java`
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20025
@zuotingbing I think all the code in SparkSQLSessionManager.scala should
gone because they are just some reflection hacks. It is possible to call
`super.init(hiveConf)` instead to get the session
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
Currently we do not call the `super.init(hiveConf)` in
`SparkSQLSessionManager.init`, it means `SessionManager.init` which includes
`createBackgroundOperationPool()` will not be called.
---
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20025
Could you please merge this to Master? Thanks @felixcheung
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85299/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #85299 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85299/testReport)**
for PR 20025 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20025
**[Test build #85299 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85299/testReport)**
for PR 20025 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20025
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20025
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
43 matches
Mail list logo
