Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20029
`addJar ` is cross-session.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85736/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20029
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20029
**[Test build #85736 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85736/testReport)**
for PR 20029 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20029
> The hiveClient created for the resourceLoader is only used to addJar,
which is, in turn, to add Jar to the shared IsolatedClientLoader. Then we can
just use the shared hive client for this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20029
**[Test build #85736 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85736/testReport)**
for PR 20029 at commit
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20029
lgtm!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20029
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20029
By [this
line](https://github.com/apache/spark/blob/master/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala#L78),
yes.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20029
> The hiveClient created for the resourceLoader is only used to addJar,
which is, in turn, to add Jar to the shared IsolatedClientLoader. Then we can
just use the shared hive client for this
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20029
@zuotingbing I took a close look at the related code and thought the issue
you raised is valid:
1. The hiveClient created for the
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20029
What it seems is never closed by your analysis is the client used to
interact with the metastore. This might be a problem which we are not aware of
in normal SQL applications, since we have only
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20029
Could you please to check this PR? Thanks @liufengdb
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20029
cc @liufengdb
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20029
`override protected lazy val resourceLoader: HiveSessionResourceLoader = {
val client: HiveClient = externalCatalog.client.newSession()
new HiveSessionResourceLoader(session,
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20029
It seems each time when connect to thrift server through beeline, the
`SessionState.start(state)` will be called two times. one is in
`HiveSessionImpl:open` , another is in
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20029
> we can find the object org.apache.spark.sql.hive.client.HiveClientImpl
and org.apache.hadoop.hive.ql.session.SessionState keep increasing
Can you check the GC root and explain why they
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20029
I'm asking you to respond to
https://github.com/apache/spark/pull/19989#issuecomment-351985114
---
-
To unsubscribe, e-mail:
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/20029
Thanks @srowen , so whom could i ping to make sure this change has no side
effects?
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20029
This indeed is the primary change as it's open vs master.
https://github.com/apache/spark/pull/19989 had some concerns about whether this
affects correctness though?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20029
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
21 matches
Mail list logo
