Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/20164
This pr is out of date. So I will close it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87058/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #87058 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87058/testReport)**
for PR 20164 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/582/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #87058 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87058/testReport)**
for PR 20164 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/20164
@WeichenXu123 Yes, my concern is that it is confusing if the transform
failure is caused by column conflict by a âinvisibleâ column.
@srowen Agree that it is not perfect if we
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20164
@srowen yeah, all models exist this issue. Although, a little difference,
for other models, it is very straightforward for user to call
`setRawPrediction` to avoid overwrite the same name
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20164
Sure but isn't this the case with any column that any model adds that
already exists -- why is this different?
---
-
To
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20164
Oh, do you mean if input df including a column named "rawPrediction", then
it will be overwritten when it transformed by OVSModel ? Looks like reasonable.
---
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20164
Sorry, I haven't understood where is the issue in current master code. The
models here should be `ClassificationModel` and will always have
`rawPrediction` param and have default value
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20164
OK, the code in question uses the `rawPredictionCol` from the `models` it
is given. Yes they'd have to be unique for this to make sense, because it adds
those raw prediction columns to the output.
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/20164
@srowen Different from the base model (like LoR), OVR and OVRModel do not
have param `rawPredictionCol`.
So if the input dataframe contains a column which has the same name as base
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20164
I might be missing something, but the user sets the raw prediction col
name. Now it's going to use a different name than what the user set.
Isn't it simply an error to apply a second model,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86157/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #86157 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86157/testReport)**
for PR 20164 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #86157 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86157/testReport)**
for PR 20164 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/20164
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86151/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #86151 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86151/testReport)**
for PR 20164 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #86151 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86151/testReport)**
for PR 20164 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/20164
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86147/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #86147 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86147/testReport)**
for PR 20164 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #86147 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86147/testReport)**
for PR 20164 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85822/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #85822 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85822/testReport)**
for PR 20164 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #85822 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85822/testReport)**
for PR 20164 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20164
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85721/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #85721 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85721/testReport)**
for PR 20164 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20164
**[Test build #85721 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85721/testReport)**
for PR 20164 at commit
37 matches
Mail list logo