[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-17 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 Thanks for everyone for review! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20239 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-17 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20239 @BryanCutler Any comments on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20239 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86048/ Test PASSed. ---

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20239 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20239 **[Test build #86048 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86048/testReport)** for PR 20239 at commit

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20239 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86043/ Test PASSed. ---

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20239 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20239 **[Test build #86043 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86043/testReport)** for PR 20239 at commit

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20239 **[Test build #86048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86048/testReport)** for PR 20239 at commit

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 `MapVector` is still used in Arrow internal code but it should not be returned to user directly.

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 @ueshin and @BryanCutler I took another look and the class `StructAccessor` defined in `ArrowColumnVector` never gets used for `getStruct`. `ArrowColumnVector.getStruct()` method just calls

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20239 **[Test build #86043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86043/testReport)** for PR 20239 at commit

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-11 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20239 Btw, I don't mean to block this pr but why does only `MapVector` have `Nullable` version, just out of curiosity. --- - To

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-11 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20239 I'm not sure we can change to `NullableMapVector` and I'm just worrying whether the `MapVector` is never happened here. --- - To

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-11 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 @BryanCutler Yes there is no error currently. This should make the code cleaner though. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20239 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85989/ Test PASSed. ---

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20239 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20239 **[Test build #85989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85989/testReport)** for PR 20239 at commit

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20239 **[Test build #85989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85989/testReport)** for PR 20239 at commit

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-11 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 @BryanCutler I think this comes up in the Arrow sync yesterday --- - To unsubscribe, e-mail:

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-11 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 cc @BryanCutler @ueshin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: