[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-19 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/20257 Merged to master / branch-2.3, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-18 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/20257 Nice, LGTM. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86269/ Test PASSed. ---

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86269/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86269/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/20257 A couple minor comments, otherwise looks fine. I see we are changing the example names, so effectively removing the old examples. I'm ok with this, unless others have an objection? ---

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86263/ Test PASSed. ---

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86263/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86263/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20257 @MLnick Changed as you suggested. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/20257 Added a few more small comments --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86244/ Test PASSed. ---

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86244/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20257 @MLnick @WeichenXu123 Your comments are addressed. Please check this again. Thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86244/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86153 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86153/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86153/ Test PASSed. ---

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86153/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-15 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20257 @MLnick Thanks for review. I think I've addressed all the comments. Please take a look for the updates. --- - To unsubscribe,

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86117/ Test PASSed. ---

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86117/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86117/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-13 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20257 cc @jkbradley @MLnick @WeichenXu123 I think we should update mllib document and example for OneHotEncoderEstimator in 2.3.0. ---

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86089/ Test PASSed. ---

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86089/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86089/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86087/ Test FAILed. ---

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86087/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86087/testReport)** for PR 20257 at commit