Github user rekhajoshm commented on the issue:
https://github.com/apache/spark/pull/20347
Thank you @srowen I admire you for doing what you do over all the jira/PR's
I have studied, and followed up.
If its ok, will keep this PR open for few days, and close if jira is
getting to
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20347
@rekhajoshm I think maybe the right resolution here is to do nothing. I
haven't heard @mengxr on his old JIRA to make this change. Thank you for
chasing down open JIRAs like this of course.
---
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20347
My major concern is that, if there is a existing `SparkContext`, some confs
you set may not take effect, as described in `SparkContext.getOrCreate()`. It's
hard to enumerate the use cases but
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20347
Yes, you can already get the new semantics here with `new
JavaSparkContext(SparkContext.getOrCreate())`.
Yes, probably better to add a new method, or else, decide that it's not
worth a new
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20347
Using `getOrCreate` in constructor seems change the semantics. Maybe we can
add a new static method for such usage in `JavaSparkContext`.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20347
@mengxr suggested this in the JIRA originally -- what was the reasoning? It
makes some sense, but so does leaving the current behavior, where a constructor
calls a constructor. It's a behavior
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20347
Can you please explain why do we need to change to `getOrCreate`?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20347
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20347
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86456/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20347
**[Test build #86456 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86456/testReport)**
for PR 20347 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20347
**[Test build #86456 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86456/testReport)**
for PR 20347 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20347
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20347
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/84/
Test
13 matches
Mail list logo
